[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: Dolphin and Baloo
From:       Emmanuel Pescosta <emmanuelpescosta099 () gmail ! com>
Date:       2014-01-27 17:16:09
Message-ID: CAH3KK-XiZ4kMfCzGqfGjNT-Vc2_9stDw5_DSZhm2HkPmxQaGhA () mail ! gmail ! com
[Download RAW message or body]

/dolphin/src/kitemviews/private/kbaloorolesprovider.cpp:
line 76 - 79: Please add {} brackets
line 82: Maybe make use of string builder!?

/dolphin/src/search/dolphinsearchinformation.cpp:
line 75: Rename it "strigiConfig" to "balooConfig" or "config"

/dolphin/src/search/dolphinsearchbox.cpp:
line 437: brackets

The rest looks pretty good ;)

+1 from my side


2014-01-27 Vishesh Handa <me@vhanda.in>

> Vishesh HandaOn Monday 16 December 2013 11:46:20  wrote:
> > Hey guys
> >
> > In case you haven't heard about Baloo, please read [1]
> >
> > Baloo offers a much faster and reliable file search than Nepomuk ever
> has.
> > Additionally, it doesn't require a process to be running all the time.
> So,
> > Dolphin queries will work even if Baloo has not started up.
> >
> > Since Nepomuk is effectively in maintenance mode, perhaps we could
> migrate
> > Dolphin away from Nepomuk. Currently, Nepomuk is a compile time switch,
> so
> > the code can easily be replaced with Baloo.
> >
> > Opinions?
>
> Hey guys
>
> Baloo is now a part of KDE SC. I'd like to merge the feature/baloo branch
> in
> kde-baseapps. It mostly works right now, though it can definitely use more
> testing.
>
> Could someone maybe review the code?
>
> Here is what currently does not work -
>
> 1. Date Time filtering when searching via Dolphin - I still haven't figured
> out a nice API for this.
>
> 2. Tagging Multiple files - It works in the most basic case, but there is
> still an odd case where it fails. I'm working on it.
>
> 3. Support for file systems which do not support xattr.
>
>
> --
> Vishesh Handa
>

[Attachment #3 (text/html)]

<div dir="ltr"><div>/dolphin/src/kitemviews/private/kbaloorolesprovider.cpp:<br>line 
  76 - 79: Please add {} brackets<br></div><div>line 82: Maybe make use of string \
builder!?<br><br>/dolphin/src/search/dolphinsearchinformation.cpp:<br></div><div>line \
75: Rename it &quot;strigiConfig&quot; to &quot;balooConfig&quot; or \
&quot;config&quot;<br> \
<br>/dolphin/src/search/dolphinsearchbox.cpp:<br></div><div>line 437: \
brackets<br><br></div><div>The rest looks pretty good ;)<br><br></div><div>+1 from my \
side<br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote"> \
2014-01-27 Vishesh Handa <span dir="ltr">&lt;<a href="mailto:me@vhanda.in" \
target="_blank">me@vhanda.in</a>&gt;</span><br><blockquote class="gmail_quote" \
style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <div \
class="im">Vishesh HandaOn Monday 16 December 2013 11:46:20  wrote:<br> &gt; Hey \
guys<br> &gt;<br>
&gt; In case you haven&#39;t heard about Baloo, please read [1]<br>
&gt;<br>
&gt; Baloo offers a much faster and reliable file search than Nepomuk ever has.<br>
&gt; Additionally, it doesn&#39;t require a process to be running all the time. \
So,<br> &gt; Dolphin queries will work even if Baloo has not started up.<br>
&gt;<br>
&gt; Since Nepomuk is effectively in maintenance mode, perhaps we could migrate<br>
&gt; Dolphin away from Nepomuk. Currently, Nepomuk is a compile time switch, so<br>
&gt; the code can easily be replaced with Baloo.<br>
&gt;<br>
&gt; Opinions?<br>
<br>
</div>Hey guys<br>
<br>
Baloo is now a part of KDE SC. I&#39;d like to merge the feature/baloo branch in<br>
kde-baseapps. It mostly works right now, though it can definitely use more<br>
testing.<br>
<br>
Could someone maybe review the code?<br>
<br>
Here is what currently does not work -<br>
<br>
1. Date Time filtering when searching via Dolphin - I still haven&#39;t figured<br>
out a nice API for this.<br>
<br>
2. Tagging Multiple files - It works in the most basic case, but there is<br>
still an odd case where it fails. I&#39;m working on it.<br>
<br>
3. Support for file systems which do not support xattr.<br>
<span class="HOEnZb"><font color="#888888"><br>
<br>
--<br>
Vishesh Handa<br>
</font></span></blockquote></div><br></div>



[prev in list] [next in list] [prev in thread] [next in thread]