From kfm-devel  Tue Jan 28 10:09:39 2014
From: Vishesh Handa <me () vhanda ! in>
Date: Tue, 28 Jan 2014 10:09:39 +0000
To: kfm-devel
Subject: Re: Dolphin and Baloo
Message-Id: <2785577.PiRuHOvoKz () vlap>
X-MARC-Message: https://marc.info/?l=kfm-devel&m=139090376409073

On Monday 27 January 2014 18:16:09 Emmanuel Pescosta wrote:
> /dolphin/src/kitemviews/private/kbaloorolesprovider.cpp:
> line 76 - 79: Please add {} brackets

Fixed

> line 82: Maybe make use of string builder!?
> 

Fixed

> /dolphin/src/search/dolphinsearchinformation.cpp:
> line 75: Rename it "strigiConfig" to "balooConfig" or "config"
> 

Fixed

> /dolphin/src/search/dolphinsearchbox.cpp:
> line 437: brackets
> 

Fixed

> The rest looks pretty good ;)
> 
> +1 from my side
>  

Thanks!

-- 
Vishesh Handa