From kfm-devel Mon Jan 27 17:16:09 2014 From: Emmanuel Pescosta Date: Mon, 27 Jan 2014 17:16:09 +0000 To: kfm-devel Subject: Re: Dolphin and Baloo Message-Id: X-MARC-Message: https://marc.info/?l=kfm-devel&m=139084298625001 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--e89a8f503bb220ebd804f0f6ddfd" --e89a8f503bb220ebd804f0f6ddfd Content-Type: text/plain; charset=ISO-8859-1 /dolphin/src/kitemviews/private/kbaloorolesprovider.cpp: line 76 - 79: Please add {} brackets line 82: Maybe make use of string builder!? /dolphin/src/search/dolphinsearchinformation.cpp: line 75: Rename it "strigiConfig" to "balooConfig" or "config" /dolphin/src/search/dolphinsearchbox.cpp: line 437: brackets The rest looks pretty good ;) +1 from my side 2014-01-27 Vishesh Handa > Vishesh HandaOn Monday 16 December 2013 11:46:20 wrote: > > Hey guys > > > > In case you haven't heard about Baloo, please read [1] > > > > Baloo offers a much faster and reliable file search than Nepomuk ever > has. > > Additionally, it doesn't require a process to be running all the time. > So, > > Dolphin queries will work even if Baloo has not started up. > > > > Since Nepomuk is effectively in maintenance mode, perhaps we could > migrate > > Dolphin away from Nepomuk. Currently, Nepomuk is a compile time switch, > so > > the code can easily be replaced with Baloo. > > > > Opinions? > > Hey guys > > Baloo is now a part of KDE SC. I'd like to merge the feature/baloo branch > in > kde-baseapps. It mostly works right now, though it can definitely use more > testing. > > Could someone maybe review the code? > > Here is what currently does not work - > > 1. Date Time filtering when searching via Dolphin - I still haven't figured > out a nice API for this. > > 2. Tagging Multiple files - It works in the most basic case, but there is > still an odd case where it fails. I'm working on it. > > 3. Support for file systems which do not support xattr. > > > -- > Vishesh Handa > --e89a8f503bb220ebd804f0f6ddfd Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
/dolphin/src/kitemviews/private/kbaloorolesprovider.c= pp:
line=20 76 - 79: Please add {} brackets
line 82: Maybe make use of = string builder!?

/dolphin/src/search/dolphinsearchinformation.cpp:
line 75: Rename it "strigiConfig" to "balooConf= ig" or "config"

/dolphin/src/search/dolphinsearchbox.cpp:
line 437: brack= ets

The rest looks pretty good ;)

+1 fr= om my side


2014-01-27 Vishesh Handa <me@vhanda.in>
Vishesh HandaOn Monday 16 December 2013 11:46:20 =A0wrote= :
> Hey guys
>
> In case you haven't heard about Baloo, please read [1]
>
> Baloo offers a much faster and reliable file search than Nepomuk ever = has.
> Additionally, it doesn't require a process to be running all the t= ime. So,
> Dolphin queries will work even if Baloo has not started up.
>
> Since Nepomuk is effectively in maintenance mode, perhaps we could mig= rate
> Dolphin away from Nepomuk. Currently, Nepomuk is a compile time switch= , so
> the code can easily be replaced with Baloo.
>
> Opinions?

Hey guys

Baloo is now a part of KDE SC. I'd like to merge the feature/baloo bran= ch in
kde-baseapps. It mostly works right now, though it can definitely use more<= br> testing.

Could someone maybe review the code?

Here is what currently does not work -

1. Date Time filtering when searching via Dolphin - I still haven't fig= ured
out a nice API for this.

2. Tagging Multiple files - It works in the most basic case, but there is still an odd case where it fails. I'm working on it.

3. Support for file systems which do not support xattr.


--
Vishesh Handa

--e89a8f503bb220ebd804f0f6ddfd--