[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: UDSEntry compression ideas
From: Mark <markg85 () gmail ! com>
Date: 2013-09-19 21:13:04
Message-ID: CAPd6JnGaR11G8m0vdEnnj-yhj0j_PQgR2oN9VE6hV3T1f3y-XA () mail ! gmail ! com
[Download RAW message or body]
On Thu, Sep 19, 2013 at 3:43 PM, Mark <markg85@gmail.com> wrote:
> On Thu, Sep 19, 2013 at 10:42 AM, Todd <toddrjen@gmail.com> wrote:
>
>>
>> On Sep 18, 2013 11:51 PM, "David Faure" <faure@kde.org> wrote:
>> >
>> > On Tuesday 17 September 2013 13:58:25 Todd wrote:
>> > > Do we need the UID and GID? Can we just store whether the file is
>> > > readable, writable, and executable? That would be three bools rather
>> than
>> > > two ints.
>> >
>> > See the property dialog, this info appears there for instance.
>> > I assume it can also be shown as an extra column in dolphin?
>> > Use lxr.kde.org to find all other users, if any.
>> >
>> > If it's just the props dialog then we could imagine returning that in
>> stat and
>> > not in listDir though. And then stating from the props dialog (it
>> currently
>> > gets it from the directory listing, when created with a kfileitem from
>> there).
>>
>> Yes, it can be shown in the file properties and info panel, but those
>> aren't needed during the directory loading. It can also be shown in
>> details view and below the file in icon view, but that can be lazy loaded.
>>
>> In terms of low-level stuff needed during directory loading, I think the
>> permissions should be enough.
>>
> I'm not sure, but the device id is an int right now, right? In that case i
> doubt that a device id will ever be as big as an int: 2147483647
> Can't we just steal 3 bits there and use it for read, write and executable?
>
> -- i haven't looked anything up in this area! --
>
Question.
If i set details to 0 i'm welcomed by a "UDSEntry::UDS_LINK_DEST" that
always seems to be: "Dummy Link Target".
When i don't set details (which means details is 2) then i don't have a
"UDSEntry::UDS_LINK_DEST" at all. That leads me to think that this
UDS_LINK_DEST might not be needed. Can i safely remove the
"UDSEntry::UDS_LINK_DEST" from the details == 0 code path?
Patch is here: http://paste.kde.org/pad68d0af/
[Attachment #3 (text/html)]
<div dir="ltr">On Thu, Sep 19, 2013 at 3:43 PM, Mark <span dir="ltr"><<a \
href="mailto:markg85@gmail.com" target="_blank">markg85@gmail.com</a>></span> \
wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote \
class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div dir="ltr"><div><div class="h5">On Thu, Sep 19, 2013 at 10:42 AM, Todd <span \
dir="ltr"><<a href="mailto:toddrjen@gmail.com" \
target="_blank">toddrjen@gmail.com</a>></span> wrote:<br></div></div><div \
class="gmail_extra">
<div><div class="h5"><div class="gmail_quote"><blockquote class="gmail_quote" \
style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div><p dir="ltr"><br>
On Sep 18, 2013 11:51 PM, "David Faure" <<a href="mailto:faure@kde.org" \
target="_blank">faure@kde.org</a>> wrote:<br> ><br>
> On Tuesday 17 September 2013 13:58:25 Todd wrote:<br>
> > Do we need the UID and GID? Can we just store whether the file is<br>
> > readable, writable, and executable? That would be three bools rather \
than<br> > > two ints.<br>
><br>
> See the property dialog, this info appears there for instance.<br>
> I assume it can also be shown as an extra column in dolphin?<br>
> Use <a href="http://lxr.kde.org" target="_blank">lxr.kde.org</a> to find all \
other users, if any.<br> ><br>
> If it's just the props dialog then we could imagine returning that in stat \
and<br> > not in listDir though. And then stating from the props dialog (it \
currently<br> > gets it from the directory listing, when created with a kfileitem \
from there).</p> </div><p dir="ltr">Yes, it can be shown in the file properties and \
info panel, but those aren't needed during the directory loading. It can also \
be shown in details view and below the file in icon view, but that can be lazy \
loaded. </p>
<p dir="ltr">In terms of low-level stuff needed during directory loading, I think the \
permissions should be enough. <br> </p>
</blockquote></div></div></div>I'm not sure, but the device id is an int right \
now, right? In that case i doubt that a device id will ever be as big as an int: \
<span style="font-size:12px;font-family:verdana,arial,helvetica,sans-serif"><a \
href="tel:2147483647" value="+12147483647" \
target="_blank">2147483647</a></span></div>
<div class="gmail_extra"><span \
style="font-size:12px;font-family:verdana,arial,helvetica,sans-serif">Can't we \
just steal 3 bits there and use it for read, write and executable?</span></div><div \
class="gmail_extra"> <span \
style="font-size:12px;font-family:verdana,arial,helvetica,sans-serif"><br></span></div><div \
class="gmail_extra"><span \
style="font-size:12px;font-family:verdana,arial,helvetica,sans-serif">-- i \
haven't looked anything up in this area! --</span></div>
</div>
</blockquote></div><br></div><div class="gmail_extra">Question.</div><div \
class="gmail_extra">If i set details to 0 i'm welcomed by a \
"UDSEntry::UDS_LINK_DEST" that always seems to be: "Dummy Link \
Target".</div>
<div class="gmail_extra">When i don't set details (which means details is 2) then \
i don't have a "UDSEntry::UDS_LINK_DEST" at all. That leads me to think \
that this UDS_LINK_DEST might not be needed. Can i safely remove the \
"UDSEntry::UDS_LINK_DEST" from the details == 0 code path?</div>
<div class="gmail_extra"><br></div><div class="gmail_extra">Patch is here: <a \
href="http://paste.kde.org/pad68d0af/">http://paste.kde.org/pad68d0af/</a></div></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic