From kfm-devel Thu Sep 19 21:13:04 2013 From: Mark Date: Thu, 19 Sep 2013 21:13:04 +0000 To: kfm-devel Subject: Re: UDSEntry compression ideas Message-Id: X-MARC-Message: https://marc.info/?l=kfm-devel&m=137962523103891 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--047d7b414aa43e3d6b04e6c30654" --047d7b414aa43e3d6b04e6c30654 Content-Type: text/plain; charset=ISO-8859-1 On Thu, Sep 19, 2013 at 3:43 PM, Mark wrote: > On Thu, Sep 19, 2013 at 10:42 AM, Todd wrote: > >> >> On Sep 18, 2013 11:51 PM, "David Faure" wrote: >> > >> > On Tuesday 17 September 2013 13:58:25 Todd wrote: >> > > Do we need the UID and GID? Can we just store whether the file is >> > > readable, writable, and executable? That would be three bools rather >> than >> > > two ints. >> > >> > See the property dialog, this info appears there for instance. >> > I assume it can also be shown as an extra column in dolphin? >> > Use lxr.kde.org to find all other users, if any. >> > >> > If it's just the props dialog then we could imagine returning that in >> stat and >> > not in listDir though. And then stating from the props dialog (it >> currently >> > gets it from the directory listing, when created with a kfileitem from >> there). >> >> Yes, it can be shown in the file properties and info panel, but those >> aren't needed during the directory loading. It can also be shown in >> details view and below the file in icon view, but that can be lazy loaded. >> >> In terms of low-level stuff needed during directory loading, I think the >> permissions should be enough. >> > I'm not sure, but the device id is an int right now, right? In that case i > doubt that a device id will ever be as big as an int: 2147483647 > Can't we just steal 3 bits there and use it for read, write and executable? > > -- i haven't looked anything up in this area! -- > Question. If i set details to 0 i'm welcomed by a "UDSEntry::UDS_LINK_DEST" that always seems to be: "Dummy Link Target". When i don't set details (which means details is 2) then i don't have a "UDSEntry::UDS_LINK_DEST" at all. That leads me to think that this UDS_LINK_DEST might not be needed. Can i safely remove the "UDSEntry::UDS_LINK_DEST" from the details == 0 code path? Patch is here: http://paste.kde.org/pad68d0af/ --047d7b414aa43e3d6b04e6c30654 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
On Thu, Sep 19, 2013 at 3:43 PM, Mark &l= t;markg85@gmail.com<= /a>> wrote:


On Sep 18, 2013 11:51 PM, "David Faure" <faure@kde.org> wrote:
>
> On Tuesday 17 September 2013 13:58:25 Todd wrote:
> > Do we need the UID and GID? =A0Can we just store whether the file= is
> > readable, writable, and executable? That would be three bools rat= her than
> > two ints.
>
> See the property dialog, this info appears there for instance.
> I assume it can also be shown as an extra column in dolphin?
> Use lxr.kde.org t= o find all other users, if any.
>
> If it's just the props dialog then we could imagine returning that= in stat and
> not in listDir though. And then stating from the props dialog (it curr= ently
> gets it from the directory listing, when created with a kfileitem from= there).

Yes, it can be shown in the file properties and info p= anel, but those aren't needed during the directory loading.=A0=A0 It ca= n also be shown in details view and below the file in icon view, but that c= an be lazy loaded.=A0

In terms of low-level stuff needed during directory loading,= I think the permissions should be enough.

I'm not sure, but the device id is an in= t right now, right? In that case i doubt that a device id will ever be as b= ig as an int:=A02147483647
Can't we just steal 3 bits there and use = it for read, write and executable?

-- i haven't looked a= nything up in this area! --

Question.
If i set details to 0 i'm welcomed by a "UD= SEntry::UDS_LINK_DEST" that always seems to be: "Dummy Link Targe= t".
When i don't set details (which means detail= s is 2) then i don't have a "UDSEntry::UDS_LINK_DEST" at all.= That leads me to think that this UDS_LINK_DEST might not be needed. Can i = safely remove the "UDSEntry::UDS_LINK_DEST" from the details =3D= =3D 0 code path?

Patch is he= re:=A0http://paste.kde.org/pad6= 8d0af/
--047d7b414aa43e3d6b04e6c30654--