[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request: Fix Bug 304299 - Dolphin launches multiple instances of a program when multiple
From: "Frank Reininghaus" <frank78ac () googlemail ! com>
Date: 2012-11-13 6:38:53
Message-ID: 20121113063853.14929.13461 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107305/#review21915
-----------------------------------------------------------
Thanks Emmanuel! The idea looks good, but I see one little issue that we should think \
about: note that the DolphinView might be embedded in a DolphinPart in Konqueror - we \
also want to behave nicely in that case. In Konqueror, one can choose (by modifying \
the settings) to open files like, e.g., images, PDFs or whatever in an embedded \
viewer inside Konqueror.
With your patch, Konqueror opens multiple images in a single Gwenview instance, which \
is certainly better than the current behaviour (open the last image that the \
itemActivated() signal has been received for in Konqueror and forget about the rest), \
but I'm not sure if that is the wanted behaviour.
@David, Dawit: can you provide some feedback about this? If the user selects multiple \
images and presses Enter, should those images be opened in an external application \
(e.g., Gwenview), or in new tabs in Konqueror?
- Frank Reininghaus
On Nov. 12, 2012, 10:44 p.m., Emmanuel Pescosta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107305/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2012, 10:44 p.m.)
>
>
> Review request for Dolphin and Frank Reininghaus.
>
>
> Description
> -------
>
> Fix Bug 304299 - Dolphin launches multiple instances of a program when multiple \
> files are selected
>
> This addresses bug 304299.
> http://bugs.kde.org/show_bug.cgi?id=304299
>
>
> Diffs
> -----
>
> dolphin/src/views/dolphinview.cpp df49634
>
> Diff: http://git.reviewboard.kde.org/r/107305/diff/
>
>
> Testing
> -------
>
> Tested with Gwenview, works fine.
>
> # Dolphin 2.1: Start one Gwenview instance for each selected image
> # Patched Dolphin: Open all selected images in one Gwenview instance
>
>
> Thanks,
>
> Emmanuel Pescosta
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107305/">http://git.reviewboard.kde.org/r/107305/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks Emmanuel! The \
idea looks good, but I see one little issue that we should think about: note that the \
DolphinView might be embedded in a DolphinPart in Konqueror - we also want to behave \
nicely in that case. In Konqueror, one can choose (by modifying the settings) to open \
files like, e.g., images, PDFs or whatever in an embedded viewer inside Konqueror.
With your patch, Konqueror opens multiple images in a single Gwenview instance, which \
is certainly better than the current behaviour (open the last image that the \
itemActivated() signal has been received for in Konqueror and forget about the rest), \
but I'm not sure if that is the wanted behaviour.
@David, Dawit: can you provide some feedback about this? If the user selects multiple \
images and presses Enter, should those images be opened in an external application \
(e.g., Gwenview), or in new tabs in Konqueror?</pre> <br />
<p>- Frank</p>
<br />
<p>On November 12th, 2012, 10:44 p.m., Emmanuel Pescosta wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Dolphin and Frank Reininghaus.</div>
<div>By Emmanuel Pescosta.</div>
<p style="color: grey;"><i>Updated Nov. 12, 2012, 10:44 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fix Bug 304299 - Dolphin launches multiple instances of a program when \
multiple files are selected</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested with Gwenview, works fine.
# Dolphin 2.1: Start one Gwenview instance for each selected image
# Patched Dolphin: Open all selected images in one Gwenview instance</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=304299">304299</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/views/dolphinview.cpp <span style="color: \
grey">(df49634)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107305/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic