This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107305/ |
Thanks Emmanuel! The idea looks good, but I see one little issue that we should think about: note that the DolphinView might be embedded in a DolphinPart in Konqueror - we also want to behave nicely in that case. In Konqueror, one can choose (by modifying the settings) to open files like, e.g., images, PDFs or whatever in an embedded viewer inside Konqueror. With your patch, Konqueror opens multiple images in a single Gwenview instance, which is certainly better than the current behaviour (open the last image that the itemActivated() signal has been received for in Konqueror and forget about the rest), but I'm not sure if that is the wanted behaviour. @David, Dawit: can you provide some feedback about this? If the user selects multiple images and presses Enter, should those images be opened in an external application (e.g., Gwenview), or in new tabs in Konqueror?
- Frank
On November 12th, 2012, 10:44 p.m., Emmanuel Pescosta wrote:
Review request for Dolphin and Frank Reininghaus.
By Emmanuel Pescosta.
Updated Nov. 12, 2012, 10:44 p.m. Description
Testing
Bugs:
304299
Diffs
|