From kfm-devel Tue Nov 13 06:38:53 2012 From: "Frank Reininghaus" Date: Tue, 13 Nov 2012 06:38:53 +0000 To: kfm-devel Subject: Re: Review Request: Fix Bug 304299 - Dolphin launches multiple instances of a program when multiple Message-Id: <20121113063853.14929.13461 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kfm-devel&m=135278874608016 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1272725029530179486==" --===============1272725029530179486== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107305/#review21915 ----------------------------------------------------------- Thanks Emmanuel! The idea looks good, but I see one little issue that we sh= ould think about: note that the DolphinView might be embedded in a DolphinP= art in Konqueror - we also want to behave nicely in that case. In Konqueror= , one can choose (by modifying the settings) to open files like, e.g., imag= es, PDFs or whatever in an embedded viewer inside Konqueror. With your patch, Konqueror opens multiple images in a single Gwenview insta= nce, which is certainly better than the current behaviour (open the last im= age that the itemActivated() signal has been received for in Konqueror and = forget about the rest), but I'm not sure if that is the wanted behaviour. @David, Dawit: can you provide some feedback about this? If the user select= s multiple images and presses Enter, should those images be opened in an ex= ternal application (e.g., Gwenview), or in new tabs in Konqueror? - Frank Reininghaus On Nov. 12, 2012, 10:44 p.m., Emmanuel Pescosta wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107305/ > ----------------------------------------------------------- > = > (Updated Nov. 12, 2012, 10:44 p.m.) > = > = > Review request for Dolphin and Frank Reininghaus. > = > = > Description > ------- > = > Fix Bug 304299 - Dolphin launches multiple instances of a program when mu= ltiple files are selected > = > = > This addresses bug 304299. > http://bugs.kde.org/show_bug.cgi?id=3D304299 > = > = > Diffs > ----- > = > dolphin/src/views/dolphinview.cpp df49634 = > = > Diff: http://git.reviewboard.kde.org/r/107305/diff/ > = > = > Testing > ------- > = > Tested with Gwenview, works fine. > = > # Dolphin 2.1: Start one Gwenview instance for each selected image > # Patched Dolphin: Open all selected images in one Gwenview instance > = > = > Thanks, > = > Emmanuel Pescosta > = > --===============1272725029530179486== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/107305/ 

Thanks Emm=
anuel! The idea looks good, but I see one little issue that we should think=
 about: note that the DolphinView might be embedded in a DolphinPart in Kon=
queror - we also want to behave nicely in that case. In Konqueror, one can =
choose (by modifying the settings) to open files like, e.g., images, PDFs o=
r whatever in an embedded viewer inside Konqueror.

With your patch, Konqueror opens multiple images in a single Gwenview insta=
nce, which is certainly better than the current behaviour (open the last im=
age that the itemActivated() signal has been received for in Konqueror and =
forget about the rest), but I'm not sure if that is the wanted behaviou=
r.

@David, Dawit: can you provide some feedback about this? If the user select=
s multiple images and presses Enter, should those images be opened in an ex=
ternal application (e.g., Gwenview), or in new tabs in Konqueror?

- Frank


On November 12th, 2012, 10:44 p.m., Emmanuel Pescosta wrote:

Review request for Dolphin and Frank Reininghaus.
By Emmanuel Pescosta.

Updated Nov. 12, 2012, 10:44 p.m.

Descripti= on 

Fix Bug 304299 - Dolphin launches multiple instances of a pr=
ogram when multiple files are selected

Testing <= /h1> 
Tested with Gwenview, works fine.

# Dolphin 2.1: Start one Gwenview instance for each selected image
# Patched Dolphin: Open all selected images in one Gwenview instance
Bugs: 304299

Diffs=

  • dolphin/src/views/dolphinview.cpp (df49634= )

View Diff
--===============1272725029530179486==--