[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request: Use QPixmapCache for KStandardItemListWidget::pixmapForIcon
From: "Christoph Feck" <christoph () maxiom ! de>
Date: 2012-10-25 21:08:25
Message-ID: 20121025210825.20758.65537 () vidsolbach ! de
[Download RAW message or body]
> On Oct. 25, 2012, 9:05 p.m., Christoph Feck wrote:
> > Sorry, QPixmapCache is obsolete, please port to KImageCache.
Before you ask, here is what the API docs say:
Deprecated:
KPixmapCache is susceptible to various non-trivial locking bugs and ineffic=
iencies, and is supported for backward compatibility only (since it exposes=
a QDataStream API for subclasses). Users should port to KImageCache for a =
very close work-alike, or KSharedDataCache if they need more control.
- Christoph
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107039/#review20922
-----------------------------------------------------------
On Oct. 25, 2012, 3:43 p.m., Emmanuel Pescosta wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107039/
> -----------------------------------------------------------
> =
> (Updated Oct. 25, 2012, 3:43 p.m.)
> =
> =
> Review request for Dolphin and Frank Reininghaus.
> =
> =
> Description
> -------
> =
> Use QPixmapCache for KStandardItemListWidget::pixmapForIcon(const QString=
& name, int size) -> Avoid KIcon loading and rescaleing
> =
> =
> Diffs
> -----
> =
> dolphin/src/kitemviews/kstandarditemlistwidget.cpp 72d10cf =
> =
> Diff: http://git.reviewboard.kde.org/r/107039/diff/
> =
> =
> Testing
> -------
> =
> According to valgrind/callgrind lesser cpu time and according to valgrind=
/massif lesser memory consume
> =
> =
> Thanks,
> =
> Emmanuel Pescosta
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107039/">http://git.reviewboard.kde.org/r/107039/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 25th, 2012, 9:05 p.m., <b>Christoph \
Feck</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Sorry, QPixmapCache is obsolete, please port to KImageCache.</pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Before you ask, here is \
what the API docs say:
Deprecated:
KPixmapCache is susceptible to various non-trivial locking bugs and inefficiencies, \
and is supported for backward compatibility only (since it exposes a QDataStream API \
for subclasses). Users should port to KImageCache for a very close work-alike, or \
KSharedDataCache if they need more control.</pre> <br />
<p>- Christoph</p>
<br />
<p>On October 25th, 2012, 3:43 p.m., Emmanuel Pescosta wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Dolphin and Frank Reininghaus.</div>
<div>By Emmanuel Pescosta.</div>
<p style="color: grey;"><i>Updated Oct. 25, 2012, 3:43 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Use QPixmapCache for KStandardItemListWidget::pixmapForIcon(const \
QString& name, int size) -> Avoid KIcon loading and rescaleing</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">According to valgrind/callgrind lesser cpu time and according to \
valgrind/massif lesser memory consume</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/kitemviews/kstandarditemlistwidget.cpp <span style="color: \
grey">(72d10cf)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107039/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic