This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107039/

On October 25th, 2012, 9:05 p.m., Christoph Feck wrote:

Sorry, QPixmapCache is obsolete, please port to KImageCache.
Before you ask, here is what the API docs say:

Deprecated:
KPixmapCache is susceptible to various non-trivial locking bugs and inefficiencies, and is supported for backward compatibility only (since it exposes a QDataStream API for subclasses). Users should port to KImageCache for a very close work-alike, or KSharedDataCache if they need more control.

- Christoph


On October 25th, 2012, 3:43 p.m., Emmanuel Pescosta wrote:

Review request for Dolphin and Frank Reininghaus.
By Emmanuel Pescosta.

Updated Oct. 25, 2012, 3:43 p.m.

Description

Use QPixmapCache for KStandardItemListWidget::pixmapForIcon(const QString& name, int size) -> Avoid KIcon loading and rescaleing

Testing

According to valgrind/callgrind lesser cpu time and according to valgrind/massif lesser memory consume

Diffs

  • dolphin/src/kitemviews/kstandarditemlistwidget.cpp (72d10cf)

View Diff