--===============3474698934614968446== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On Oct. 25, 2012, 9:05 p.m., Christoph Feck wrote: > > Sorry, QPixmapCache is obsolete, please port to KImageCache. Before you ask, here is what the API docs say: Deprecated: KPixmapCache is susceptible to various non-trivial locking bugs and ineffic= iencies, and is supported for backward compatibility only (since it exposes= a QDataStream API for subclasses). Users should port to KImageCache for a = very close work-alike, or KSharedDataCache if they need more control. - Christoph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107039/#review20922 ----------------------------------------------------------- On Oct. 25, 2012, 3:43 p.m., Emmanuel Pescosta wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107039/ > ----------------------------------------------------------- > = > (Updated Oct. 25, 2012, 3:43 p.m.) > = > = > Review request for Dolphin and Frank Reininghaus. > = > = > Description > ------- > = > Use QPixmapCache for KStandardItemListWidget::pixmapForIcon(const QString= & name, int size) -> Avoid KIcon loading and rescaleing > = > = > Diffs > ----- > = > dolphin/src/kitemviews/kstandarditemlistwidget.cpp 72d10cf = > = > Diff: http://git.reviewboard.kde.org/r/107039/diff/ > = > = > Testing > ------- > = > According to valgrind/callgrind lesser cpu time and according to valgrind= /massif lesser memory consume > = > = > Thanks, > = > Emmanuel Pescosta > = > --===============3474698934614968446== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/107039/

On October 25th, 2012, 9:05 p.m., Christoph= Feck wrote:
Sorry, QP=
ixmapCache is obsolete, please port to KImageCache.

Before you =
ask, here is what the API docs say:

Deprecated:
KPixmapCache is susceptible to various non-trivial locking bugs and ineffic=
iencies, and is supported for backward compatibility only (since it exposes=
 a QDataStream API for subclasses). Users should port to KImageCache for a =
very close work-alike, or KSharedDataCache if they need more control.

- Christoph

On October 25th, 2012, 3:43 p.m., Emmanuel Pescosta wrote:

Review request for Dolphin and Frank Reininghaus.

By Emmanuel Pescosta.

Updated Oct. 25, 2012, 3:43 p.m.

Descripti= on

Use QPixmapCache for KStandardItemListWidget::pixmapForIcon(=
const QString& name, int size) -> Avoid KIcon loading and rescaleing=

Testing <= /h1>

According to valgrind/callgrind lesser cpu time and accordin=
g to valgrind/massif lesser memory consume

Diffs=

dolphin/src/kitemviews/kstandarditemlistwidget.cpp (72d10cf)

--===============3474698934614968446==--