[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request: Implemented multithreading in KFileItemModelSortAlgorithm
From: "Emmanuel Pescosta" <emmanuelpescosta099 () gmail ! com>
Date: 2012-10-25 11:48:01
Message-ID: 20121025114801.4462.6222 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107025/
-----------------------------------------------------------
(Updated Oct. 25, 2012, 11:48 a.m.)
Review request for Dolphin and Frank Reininghaus.
Changes
-------
Use as many threads as possible.
Btw.: It is faster than the 2-thread implementation, about 600 ms with 500.000 files \
=> Never run a cpu expensive background process while benchmarking :(
Description
-------
Implemented multithreading in KFileItemModelSortAlgorithm.
If more than 100 items to sort and ideal thread count is greater than 1 -> sort them \
with parallelSort (2 Threads)
Use maximal 2 Threads, because more than 2 Threads are "slower" (more overhead than \
speed up). (I also have a patch which uses n Threads for sorting, if you want test it \
;)
Diffs (updated)
-----
dolphin/src/kitemviews/private/kfileitemmodelsortalgorithm.h 3a596df
dolphin/src/kitemviews/private/kfileitemmodelsortalgorithm.cpp e0aac13
Diff: http://git.reviewboard.kde.org/r/107025/diff/
Testing
-------
About 2 seconds faster with sorting 500.000 files.
About 5 seconds faster with sorting 1.000.000 files.
Thanks,
Emmanuel Pescosta
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107025/">http://git.reviewboard.kde.org/r/107025/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Dolphin and Frank Reininghaus.</div>
<div>By Emmanuel Pescosta.</div>
<p style="color: grey;"><i>Updated Oct. 25, 2012, 11:48 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Use as many threads as possible.
Btw.: It is faster than the 2-thread implementation, about 600 ms with 500.000 files \
=> Never run a cpu expensive background process while benchmarking :(</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Implemented multithreading in KFileItemModelSortAlgorithm.
If more than 100 items to sort and ideal thread count is greater than 1 -> sort \
them with parallelSort (2 Threads)
Use maximal 2 Threads, because more than 2 Threads are "slower" (more \
overhead than speed up). (I also have a patch which uses n Threads for sorting, if \
you want test it ;)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">About 2 seconds faster with sorting 500.000 files. About 5 seconds \
faster with sorting 1.000.000 files.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/kitemviews/private/kfileitemmodelsortalgorithm.h <span style="color: \
grey">(3a596df)</span></li>
<li>dolphin/src/kitemviews/private/kfileitemmodelsortalgorithm.cpp <span \
style="color: grey">(e0aac13)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107025/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic