[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request: Fix Bug 304643 - selected place looks ugly and incomplete
From: "Emmanuel Pescosta" <emmanuelpescosta099 () gmail ! com>
Date: 2012-10-25 11:55:33
Message-ID: 20121025115533.5126.12807 () vidsolbach ! de
[Download RAW message or body]
> On Oct. 15, 2012, 3:43 p.m., Frank Reininghaus wrote:
> > First of all, thanks for the patch and the screenshots!
> >
> > It should be added that the "new" look would match the look of KFilePlacesView, \
> > i.e., the look of Dolphin's Places Panel in KDE <= 4.8. In particular, it makes \
> > sure that the red color of the "Root" place is preserved (the user who reported \
> > this considered the color change distracting, and I agree that it can be \
> > considered a bit odd).
> > However, when we change this, the behaviour of the Places Panel would be \
> > different from the one of the DolphinView. This is most obvious when using \
> > Details View. I'm not really sure what the best solution is. There are several \
> > options:
> > a) Apply the patch as it is.
> > b) Only remove the color change, and do not extend the selection rectangle.
> > c) Don't change anything.
> > d) Like a), but do the same change in the DolphinView.
> > e) Like b), but do the same change in the DolphinView.
> >
> > I'm not entirely sure what the 'right' approach is, but considering that the wish \
> > report did not get much feedback, it's not clear if it's really worth adding \
> > extra complexity to implement this.
> > Any other opinions? Do we know how other file managers do it (I don't have any \
> > others to test here right now)?
>
> Emmanuel Pescosta wrote:
> I implemented option d.) So you can decide what looks better, the old or the new \
> Dolphin look. ;)
> I hope you and the other Dolphin users like it.
>
> Frank Reininghaus wrote:
> Thanks for the new patch, Emmanuel!
>
> I'm still not quite sure what look is best :-/
Should I push or discard my patch? ;) (What if we ask the other people on planetkde \
or on the mailing-list?)
- Emmanuel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106827/#review20387
-----------------------------------------------------------
On Oct. 17, 2012, 7:42 p.m., Emmanuel Pescosta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106827/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2012, 7:42 p.m.)
>
>
> Review request for Dolphin and Frank Reininghaus.
>
>
> Description
> -------
>
> Fix Bug 304643 - selected place looks ugly and incomplete
>
>
> This addresses bug 304643.
> http://bugs.kde.org/show_bug.cgi?id=304643
>
>
> Diffs
> -----
>
> dolphin/src/kitemviews/kitemlistwidget.h 55181fa
> dolphin/src/kitemviews/kitemlistwidget.cpp 6a7111a
> dolphin/src/kitemviews/kstandarditemlistwidget.h 787722d
> dolphin/src/kitemviews/kstandarditemlistwidget.cpp 72d10cf
> dolphin/src/panels/folders/foldersitemlistwidget.cpp b4f9a5b
> dolphin/src/panels/places/placesitemlistwidget.h a2a88c1
> dolphin/src/panels/places/placesitemlistwidget.cpp e33d1da
>
> Diff: http://git.reviewboard.kde.org/r/106827/diff/
>
>
> Testing
> -------
>
>
> Screenshots
> -----------
>
> Old and new Dolphin Places look
> http://git.reviewboard.kde.org/r/106827/s/779/
>
>
> Thanks,
>
> Emmanuel Pescosta
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106827/">http://git.reviewboard.kde.org/r/106827/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 15th, 2012, 3:43 p.m., <b>Frank \
Reininghaus</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">First of all, thanks for the patch and the screenshots!
It should be added that the "new" look would match the look of \
KFilePlacesView, i.e., the look of Dolphin's Places Panel in KDE <= 4.8. In \
particular, it makes sure that the red color of the "Root" place is \
preserved (the user who reported this considered the color change distracting, and I \
agree that it can be considered a bit odd).
However, when we change this, the behaviour of the Places Panel would be different \
from the one of the DolphinView. This is most obvious when using Details View. \
I'm not really sure what the best solution is. There are several options:
a) Apply the patch as it is.
b) Only remove the color change, and do not extend the selection rectangle.
c) Don't change anything.
d) Like a), but do the same change in the DolphinView.
e) Like b), but do the same change in the DolphinView.
I'm not entirely sure what the 'right' approach is, but considering that \
the wish report did not get much feedback, it's not clear if it's really \
worth adding extra complexity to implement this.
Any other opinions? Do we know how other file managers do it (I don't have any \
others to test here right now)? </pre>
</blockquote>
<p>On October 17th, 2012, 7:46 p.m., <b>Emmanuel Pescosta</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I implemented option d.) \
So you can decide what looks better, the old or the new Dolphin look. ;)
I hope you and the other Dolphin users like it.</pre>
</blockquote>
<p>On October 19th, 2012, 11:50 a.m., <b>Frank Reininghaus</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for the new \
patch, Emmanuel!
I'm still not quite sure what look is best :-/</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Should I push or discard \
my patch? ;) (What if we ask the other people on planetkde or on the \
mailing-list?)</pre> <br />
<p>- Emmanuel</p>
<br />
<p>On October 17th, 2012, 7:42 p.m., Emmanuel Pescosta wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Dolphin and Frank Reininghaus.</div>
<div>By Emmanuel Pescosta.</div>
<p style="color: grey;"><i>Updated Oct. 17, 2012, 7:42 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fix Bug 304643 - selected place looks ugly and incomplete</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=304643">304643</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/kitemviews/kitemlistwidget.h <span style="color: \
grey">(55181fa)</span></li>
<li>dolphin/src/kitemviews/kitemlistwidget.cpp <span style="color: \
grey">(6a7111a)</span></li>
<li>dolphin/src/kitemviews/kstandarditemlistwidget.h <span style="color: \
grey">(787722d)</span></li>
<li>dolphin/src/kitemviews/kstandarditemlistwidget.cpp <span style="color: \
grey">(72d10cf)</span></li>
<li>dolphin/src/panels/folders/foldersitemlistwidget.cpp <span style="color: \
grey">(b4f9a5b)</span></li>
<li>dolphin/src/panels/places/placesitemlistwidget.h <span style="color: \
grey">(a2a88c1)</span></li>
<li>dolphin/src/panels/places/placesitemlistwidget.cpp <span style="color: \
grey">(e33d1da)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106827/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/106827/s/779/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/10/15/dolphin_places_400x100.png" \
style="border: 1px black solid;" alt="Old and new Dolphin Places look" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic