--===============3445021827472255049== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107025/ ----------------------------------------------------------- (Updated Oct. 25, 2012, 11:48 a.m.) Review request for Dolphin and Frank Reininghaus. Changes ------- Use as many threads as possible. Btw.: It is faster than the 2-thread implementation, about 600 ms with 500.= 000 files =3D> Never run a cpu expensive background process while benchmark= ing :( Description ------- Implemented multithreading in KFileItemModelSortAlgorithm. If more than 100 items to sort and ideal thread count is greater than 1 -> = sort them with parallelSort (2 Threads) Use maximal 2 Threads, because more than 2 Threads are "slower" (more overh= ead than speed up). (I also have a patch which uses n Threads for sorting, = if you want test it ;) Diffs (updated) ----- dolphin/src/kitemviews/private/kfileitemmodelsortalgorithm.h 3a596df = dolphin/src/kitemviews/private/kfileitemmodelsortalgorithm.cpp e0aac13 = Diff: http://git.reviewboard.kde.org/r/107025/diff/ Testing ------- About 2 seconds faster with sorting 500.000 files. About 5 seconds faster with sorting 1.000.000 files. Thanks, Emmanuel Pescosta --===============3445021827472255049== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/107025/

Review request for Dolphin and Frank Reininghaus.
By Emmanuel Pescosta.

Updated Oct. 25, 2012, 11:48 a.m.

Changes 
Use as many threads as possible.

Btw.: It is faster than the 2-thread implementation, about 600 ms with 500.=
000 files =3D> Never run a cpu expensive background process while benchm=
arking :(

Descripti= on 

Implemented multithreading in KFileItemModelSortAlgorithm.

If more than 100 items to sort and ideal thread count is greater than 1 -&g=
t; sort them with parallelSort (2 Threads)

Use maximal 2 Threads, because more than 2 Threads are "slower" (=
more overhead than speed up). (I also have a patch which uses n Threads for=
 sorting, if you want test it ;)

Testing <= /h1> 
About 2 seconds faster with sorting 500.000 files.
About 5 seconds faster with sorting 1.000.000 files.

Diffs= (updated)

  • dolphin/src/kitemviews/private/kfileitemmodelsortalgorithm.h (3a596df)
  • dolphin/src/kitemviews/private/kfileitemmodelsortalgorithm.cpp (e0aac13)

View Diff
--===============3445021827472255049==--