[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request: Add support for MTP devices
From: "Alex Fiestas" <alex () eyeos ! org>
Date: 2012-09-30 0:42:25
Message-ID: 20120930004225.26949.16112 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106651/
-----------------------------------------------------------
(Updated Sept. 30, 2012, 12:42 a.m.)
Review request for Dolphin.
Description (updated)
-------
Add support for MTP devices only if the mtp kio slave is installed.
The patch is prepared to support ptp as well (that's why I put some code in=
to isDeviceSupported). =
Diffs
-----
dolphin/src/panels/places/placesitem.h 5a24a52 =
dolphin/src/panels/places/placesitem.cpp f72f639 =
dolphin/src/panels/places/placesitemmodel.h 463e564 =
dolphin/src/panels/places/placesitemmodel.cpp 4770c6b =
Diff: http://git.reviewboard.kde.org/r/106651/diff/
Testing
-------
Thanks,
Alex Fiestas
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106651/">http://git.reviewboard.kde.org/r/106651/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Dolphin.</div>
<div>By Alex Fiestas.</div>
<p style="color: grey;"><i>Updated Sept. 30, 2012, 12:42 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add support for MTP devices only if the mtp kio slave is installed.
The patch is prepared to support ptp as well (that's why I put some code into \
isDeviceSupported). </pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/panels/places/placesitem.h <span style="color: \
grey">(5a24a52)</span></li>
<li>dolphin/src/panels/places/placesitem.cpp <span style="color: \
grey">(f72f639)</span></li>
<li>dolphin/src/panels/places/placesitemmodel.h <span style="color: \
grey">(463e564)</span></li>
<li>dolphin/src/panels/places/placesitemmodel.cpp <span style="color: \
grey">(4770c6b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106651/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic