[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request: Adding Accessibility Interfaces for Dolphin Views & Widgets
From: "Frank Reininghaus" <frank78ac () googlemail ! com>
Date: 2012-08-23 13:38:27
Message-ID: 20120823133827.21996.41087 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105972/#review17902
-----------------------------------------------------------
Sorry for my late response, I was away for a couple of days.
How can I test your patch? I think that only applying the Dolphin patch is =
not sufficient, so I'd like to know what else I need to download+build. I'd=
like to test it myself so I can make sure that the adjustments I'll make i=
n Dolphin's code (like making the number of rows and columns accessible) wo=
rk correctly in all view modes and with grouping enabled.
- Frank Reininghaus
On Aug. 17, 2012, 11:20 a.m., Amandeep Singh wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105972/
> -----------------------------------------------------------
> =
> (Updated Aug. 17, 2012, 11:20 a.m.)
> =
> =
> Review request for Dolphin, KDE Base Apps and KDE Accessibility.
> =
> =
> Description
> -------
> =
> Added Accessibility Interfaces for Dolphin Views & Widgets, to make it ac=
cessible.
> 2 New files added in dolphin/ src/ kitemviews/ kitemlistviewaccessible.* =
that contain the three new classes.
> =
> =
> Diffs
> -----
> =
> dolphin/src/CMakeLists.txt afc190f =
> dolphin/src/kitemviews/kitemlistcontroller.cpp 88f5d9f =
> dolphin/src/kitemviews/kitemlistview.h 5723b9a =
> dolphin/src/kitemviews/kitemlistview.cpp 72b3fd8 =
> dolphin/src/kitemviews/kitemlistviewaccessible.h PRE-CREATION =
> dolphin/src/kitemviews/kitemlistviewaccessible.cpp PRE-CREATION =
> dolphin/src/kitemviews/private/kitemlistviewlayouter.h da5bd1d =
> dolphin/src/tests/CMakeLists.txt 3f906d1 =
> =
> Diff: http://git.reviewboard.kde.org/r/105972/diff/
> =
> =
> Testing
> -------
> =
> Focus-tracking tested with KMag / KWin. =
> =
> =
> Thanks,
> =
> Amandeep Singh
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105972/">http://git.reviewboard.kde.org/r/105972/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry for my late \
response, I was away for a couple of days.
How can I test your patch? I think that only applying the Dolphin patch is not \
sufficient, so I'd like to know what else I need to download+build. I'd like \
to test it myself so I can make sure that the adjustments I'll make in \
Dolphin's code (like making the number of rows and columns accessible) work \
correctly in all view modes and with grouping enabled.</pre> <br />
<p>- Frank</p>
<br />
<p>On August 17th, 2012, 11:20 a.m., Amandeep Singh wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Dolphin, KDE Base Apps and KDE Accessibility.</div>
<div>By Amandeep Singh.</div>
<p style="color: grey;"><i>Updated Aug. 17, 2012, 11:20 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Added Accessibility Interfaces for Dolphin Views & Widgets, to make \
it accessible. 2 New files added in dolphin/ src/ kitemviews/ \
kitemlistviewaccessible.* that contain the three new classes.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Focus-tracking tested with KMag / KWin. </pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/CMakeLists.txt <span style="color: grey">(afc190f)</span></li>
<li>dolphin/src/kitemviews/kitemlistcontroller.cpp <span style="color: \
grey">(88f5d9f)</span></li>
<li>dolphin/src/kitemviews/kitemlistview.h <span style="color: \
grey">(5723b9a)</span></li>
<li>dolphin/src/kitemviews/kitemlistview.cpp <span style="color: \
grey">(72b3fd8)</span></li>
<li>dolphin/src/kitemviews/kitemlistviewaccessible.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>dolphin/src/kitemviews/kitemlistviewaccessible.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>dolphin/src/kitemviews/private/kitemlistviewlayouter.h <span style="color: \
grey">(da5bd1d)</span></li>
<li>dolphin/src/tests/CMakeLists.txt <span style="color: grey">(3f906d1)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105972/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic