From kfm-devel Thu Aug 23 13:38:27 2012 From: "Frank Reininghaus" Date: Thu, 23 Aug 2012 13:38:27 +0000 To: kfm-devel Subject: Re: Review Request: Adding Accessibility Interfaces for Dolphin Views & Widgets Message-Id: <20120823133827.21996.41087 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kfm-devel&m=134572914127293 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============6496767481434520586==" --===============6496767481434520586== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105972/#review17902 ----------------------------------------------------------- Sorry for my late response, I was away for a couple of days. How can I test your patch? I think that only applying the Dolphin patch is = not sufficient, so I'd like to know what else I need to download+build. I'd= like to test it myself so I can make sure that the adjustments I'll make i= n Dolphin's code (like making the number of rows and columns accessible) wo= rk correctly in all view modes and with grouping enabled. - Frank Reininghaus On Aug. 17, 2012, 11:20 a.m., Amandeep Singh wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105972/ > ----------------------------------------------------------- > = > (Updated Aug. 17, 2012, 11:20 a.m.) > = > = > Review request for Dolphin, KDE Base Apps and KDE Accessibility. > = > = > Description > ------- > = > Added Accessibility Interfaces for Dolphin Views & Widgets, to make it ac= cessible. > 2 New files added in dolphin/ src/ kitemviews/ kitemlistviewaccessible.* = that contain the three new classes. > = > = > Diffs > ----- > = > dolphin/src/CMakeLists.txt afc190f = > dolphin/src/kitemviews/kitemlistcontroller.cpp 88f5d9f = > dolphin/src/kitemviews/kitemlistview.h 5723b9a = > dolphin/src/kitemviews/kitemlistview.cpp 72b3fd8 = > dolphin/src/kitemviews/kitemlistviewaccessible.h PRE-CREATION = > dolphin/src/kitemviews/kitemlistviewaccessible.cpp PRE-CREATION = > dolphin/src/kitemviews/private/kitemlistviewlayouter.h da5bd1d = > dolphin/src/tests/CMakeLists.txt 3f906d1 = > = > Diff: http://git.reviewboard.kde.org/r/105972/diff/ > = > = > Testing > ------- > = > Focus-tracking tested with KMag / KWin. = > = > = > Thanks, > = > Amandeep Singh > = > --===============6496767481434520586== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/105972/ 

Sorry for =
my late response, I was away for a couple of days.

How can I test your patch? I think that only applying the Dolphin patch is =
not sufficient, so I'd like to know what else I need to download+build.=
 I'd like to test it myself so I can make sure that the adjustments I&#=
39;ll make in Dolphin's code (like making the number of rows and column=
s accessible) work correctly in all view modes and with grouping enabled.
 









- Frank






On August 17th, 2012, 11:20 a.m., Amandeep Singh wrote:









 

  


Review request for Dolphin, KDE Base Apps and KDE Accessibility.


By Amandeep Singh.




Updated Aug. 17, 2012, 11:20 a.m.








Descripti=
on 

 

 

  
   
Added Accessibility Interfaces for Dolphin Views & Widge=
ts, to make it accessible.
2 New files added in dolphin/ src/ kitemviews/ kitemlistviewaccessible.* th=
at contain the three new classes.

  		
 






Testing <=
/h1>


 

  
   
Focus-tracking tested with KMag / KWin. 

  		
 








Diffs=
 


    

 
  • dolphin/src/CMakeLists.txt (afc190f)
    • 

 
  • dolphin/src/kitemviews/kitemlistcontroller.cpp (88f5d9f)
    • 

 
  • dolphin/src/kitemviews/kitemlistview.h (57=
23b9a)
    • 

 
  • dolphin/src/kitemviews/kitemlistview.cpp (=
72b3fd8)
    • 

 
  • dolphin/src/kitemviews/kitemlistviewaccessible.h (PRE-CREATION)
    • 

 
  • dolphin/src/kitemviews/kitemlistviewaccessible.cpp (PRE-CREATION)
    • 

 
  • dolphin/src/kitemviews/private/kitemlistviewlayouter.h (da5bd1d)
    • 

 
  • dolphin/src/tests/CMakeLists.txt (3f906d1)=

    • 





View Diff
--===============6496767481434520586==--