This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105972/ 

Sorry for my late response, I was away for a couple of days.

How can I test your patch? I think that only applying the Dolphin patch is not sufficient, so I'd like to know what else I need to download+build. I'd like to test it myself so I can make sure that the adjustments I'll make in Dolphin's code (like making the number of rows and columns accessible) work correctly in all view modes and with grouping enabled.

- Frank


On August 17th, 2012, 11:20 a.m., Amandeep Singh wrote:

Review request for Dolphin, KDE Base Apps and KDE Accessibility.
By Amandeep Singh.

Updated Aug. 17, 2012, 11:20 a.m.

Description 

Added Accessibility Interfaces for Dolphin Views & Widgets, to make it accessible.
2 New files added in dolphin/ src/ kitemviews/ kitemlistviewaccessible.* that contain the three new classes.

Testing 

Focus-tracking tested with KMag / KWin.

Diffs

  • dolphin/src/CMakeLists.txt (afc190f)
  • dolphin/src/kitemviews/kitemlistcontroller.cpp (88f5d9f)
  • dolphin/src/kitemviews/kitemlistview.h (5723b9a)
  • dolphin/src/kitemviews/kitemlistview.cpp (72b3fd8)
  • dolphin/src/kitemviews/kitemlistviewaccessible.h (PRE-CREATION)
  • dolphin/src/kitemviews/kitemlistviewaccessible.cpp (PRE-CREATION)
  • dolphin/src/kitemviews/private/kitemlistviewlayouter.h (da5bd1d)
  • dolphin/src/tests/CMakeLists.txt (3f906d1)

View Diff