[prev in list] [next in list] [prev in thread] [next in thread]
List: kfm-devel
Subject: Re: Review Request: Bug 196263 - Middle clicking a folder in the locations panel shouldn't activate
From: "Frank Reininghaus" <frank78ac () googlemail ! com>
Date: 2012-08-23 13:22:33
Message-ID: 20120823132233.20964.4312 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106069/#review17899
-----------------------------------------------------------
Ship it!
Thanks for the patch! I agree that this makes middle-clicking items in different \
parts of Dolphin more consistent.
But I think that this should only go into master, not the 4.9 branch, because I \
prefer not to have behaviour changes like this in bug fix releases.
BTW, I think the slot openNewActivatedTab() in DolphinMainWindow is not needed any \
more when your patch is applied, right?
- Frank Reininghaus
On Aug. 18, 2012, 9:25 a.m., Emmanuel Pescosta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106069/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2012, 9:25 a.m.)
>
>
> Review request for Dolphin and Frank Reininghaus.
>
>
> Description
> -------
>
> Changed the behaviour when middle clicking folders in places- and folders-panel. \
> Now it opens the folders in a new background tab (General behaviour of Dolphin).
>
> This addresses bug 196263.
> http://bugs.kde.org/show_bug.cgi?id=196263
>
>
> Diffs
> -----
>
> dolphin/src/dolphinmainwindow.cpp f3d23d6
>
> Diff: http://git.reviewboard.kde.org/r/106069/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Emmanuel Pescosta
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106069/">http://git.reviewboard.kde.org/r/106069/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for the patch! I \
agree that this makes middle-clicking items in different parts of Dolphin more \
consistent.
But I think that this should only go into master, not the 4.9 branch, because I \
prefer not to have behaviour changes like this in bug fix releases.
BTW, I think the slot openNewActivatedTab() in DolphinMainWindow is not needed any \
more when your patch is applied, right?</pre> <br />
<p>- Frank</p>
<br />
<p>On August 18th, 2012, 9:25 a.m., Emmanuel Pescosta wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Dolphin and Frank Reininghaus.</div>
<div>By Emmanuel Pescosta.</div>
<p style="color: grey;"><i>Updated Aug. 18, 2012, 9:25 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Changed the behaviour when middle clicking folders in places- and \
folders-panel. Now it opens the folders in a new background tab (General behaviour of \
Dolphin). </pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=196263">196263</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/dolphinmainwindow.cpp <span style="color: \
grey">(f3d23d6)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106069/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic