From kfm-devel Thu Aug 23 13:22:33 2012 From: "Frank Reininghaus" Date: Thu, 23 Aug 2012 13:22:33 +0000 To: kfm-devel Subject: Re: Review Request: Bug 196263 - Middle clicking a folder in the locations panel shouldn't activate Message-Id: <20120823132233.20964.4312 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kfm-devel&m=134572816726971 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============8270972345140367389==" --===============8270972345140367389== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106069/#review17899 ----------------------------------------------------------- Ship it! Thanks for the patch! I agree that this makes middle-clicking items in diff= erent parts of Dolphin more consistent. But I think that this should only go into master, not the 4.9 branch, becau= se I prefer not to have behaviour changes like this in bug fix releases. BTW, I think the slot openNewActivatedTab() in DolphinMainWindow is not nee= ded any more when your patch is applied, right? - Frank Reininghaus On Aug. 18, 2012, 9:25 a.m., Emmanuel Pescosta wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106069/ > ----------------------------------------------------------- > = > (Updated Aug. 18, 2012, 9:25 a.m.) > = > = > Review request for Dolphin and Frank Reininghaus. > = > = > Description > ------- > = > Changed the behaviour when middle clicking folders in places- and folders= -panel. Now it opens the folders in a new background tab (General behaviour= of Dolphin). > = > = > This addresses bug 196263. > http://bugs.kde.org/show_bug.cgi?id=3D196263 > = > = > Diffs > ----- > = > dolphin/src/dolphinmainwindow.cpp f3d23d6 = > = > Diff: http://git.reviewboard.kde.org/r/106069/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > Emmanuel Pescosta > = > --===============8270972345140367389== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/106069/

Ship it!

Thanks for=
 the patch! I agree that this makes middle-clicking items in different part=
s of Dolphin more consistent.

But I think that this should only go into master, not the 4.9 branch, becau=
se I prefer not to have behaviour changes like this in bug fix releases.

BTW, I think the slot openNewActivatedTab() in DolphinMainWindow is not nee=
ded any more when your patch is applied, right?

- Frank

On August 18th, 2012, 9:25 a.m., Emmanuel Pescosta wrote:

Review request for Dolphin and Frank Reininghaus.

By Emmanuel Pescosta.

Updated Aug. 18, 2012, 9:25 a.m.

Descripti= on

Changed the behaviour when middle clicking folders in places=
- and folders-panel. Now it opens the folders in a new background tab (Gene=
ral behaviour of Dolphin).

Bugs: 196263

Diffs=

dolphin/src/dolphinmainwindow.cpp (f3d23d6= )

View Diff

--===============8270972345140367389==--