[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: Bug#39711: kio-http ignores HTTP cache control commands
From:       Waldo Bastian <bastian () kde ! org>
Date:       2002-03-24 18:45:29
[Download RAW message or body]

On Sunday 24 March 2002 06:42 am, Dirk Mueller wrote:
> On Sam, 23 Mär 2002, Waldo Bastian wrote:
> > Ideally we should also distinguish between a normal page load and
> > accessing the history, because when we go back in the history we should
> > ignore "Expired".
>
> Thats what we're doing actually.
>
> > [ Remark for other khtml developers: the above code looks buggy, when
> > "reload" is true the entry in the cache will be replaced with a new entry
> > ignoring the refcount of the original entry. ]
>
> How can you have a refcounted image not in the cache ?

Cache::cache is a QDict, when reload is true and an entry for that url was 
already present it is ignored and a new entry for that url is created. I 
thought that a QDict would delete the already existing item, but I now see 
that it remains in the QDict but just isn't accessible. So it doesn't get 
deleted although I doubt it will work correctly, since Cache::flush will not 
be able to flush the item that is no longer in use (since it is hidden behind 
the new item for the same url)

Cheers,
Waldo
-- 
bastian@kde.org  |   SuSE Labs KDE Developer  |  bastian@suse.com

[prev in list] [next in list] [prev in thread] [next in thread]