From kfm-devel  Sun Mar 24 18:45:29 2002
From: Waldo Bastian <bastian () kde ! org>
Date: Sun, 24 Mar 2002 18:45:29 +0000
To: kfm-devel
Subject: Re: Bug#39711: kio-http ignores HTTP cache control commands
X-MARC-Message: https://marc.info/?l=kfm-devel&m=101699572517052

On Sunday 24 March 2002 06:42 am, Dirk Mueller wrote:
> On Sam, 23 M=E4r 2002, Waldo Bastian wrote:
> > Ideally we should also distinguish between a normal page load and
> > accessing the history, because when we go back in the history we shou=
ld
> > ignore "Expired".
>
> Thats what we're doing actually.
>
> > [ Remark for other khtml developers: the above code looks buggy, when
> > "reload" is true the entry in the cache will be replaced with a new e=
ntry
> > ignoring the refcount of the original entry. ]
>
> How can you have a refcounted image not in the cache ?

Cache::cache is a QDict, when reload is true and an entry for that url wa=
s=20
already present it is ignored and a new entry for that url is created. I=20
thought that a QDict would delete the already existing item, but I now se=
e=20
that it remains in the QDict but just isn't accessible. So it doesn't get=
=20
deleted although I doubt it will work correctly, since Cache::flush will =
not=20
be able to flush the item that is no longer in use (since it is hidden be=
hind=20
the new item for the same url)

Cheers,
Waldo
--=20
bastian@kde.org  |   SuSE Labs KDE Developer  |  bastian@suse.com