--===============0930914402== Content-Type: multipart/alternative; boundary="===============1130161191010904904==" --===============1130161191010904904== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6345/#review9654 ----------------------------------------------------------- Ship it! looks good - Ralf On Jan. 16, 2011, 11:28 p.m., Wolfgang Rohdewald wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6345/ > ----------------------------------------------------------- > = > (Updated Jan. 16, 2011, 11:28 p.m.) > = > = > Review request for kde-windows. > = > = > Summary > ------- > = > EmergeBase.__init__: if the object does not yet have attribute > buildSystemType, set it to None. This makes referencing this > attribute easier because "if hasattr()" is no longer needed. And > it makes pylint happy. > The same thing has already been done with subinfo, r1214441, which > resulted in no complaints or problems > = > = > Diffs > ----- > = > /trunk/kdesupport/emerge/bin/EmergeBase.py 1214807 = > /trunk/kdesupport/emerge/bin/Package/PackageBase.py 1214807 = > /trunk/kdesupport/emerge/bin/Packager/NullsoftInstallerPackager.py 1214= 807 = > /trunk/kdesupport/emerge/bin/Source/ArchiveSource.py 1214807 = > /trunk/kdesupport/emerge/bin/Source/FileSource.py 1214807 = > /trunk/kdesupport/emerge/bin/Source/SourceBase.py 1214807 = > = > Diff: http://svn.reviewboard.kde.org/r/6345/diff > = > = > Testing > ------- > = > = > Thanks, > = > Wolfgang > = > --===============1130161191010904904== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/6345/

Ship it!

looks good=

- Ralf


On January 16th, 2011, 11:28 p.m., Wolfgang Rohdewald wrote:

Review request for kde-windows.
By Wolfgang Rohdewald.

Updated Jan. 16, 2011, 11:28 p.m.

Descripti= on 

    EmergeBase.__init__: if the object does not yet have att=
ribute
    buildSystemType, set it to None. This makes referencing this
    attribute easier because "if hasattr()" is no longer needed. =
And
    it makes pylint happy.
    The same thing has already been done with subinfo, r1214441, which
    resulted in no complaints or problems

Diffs=

  • /trunk/kdesupport/emerge/bin/EmergeBase.py (1214807)
  • /trunk/kdesupport/emerge/bin/Package/PackageBase.py (1214807)
  • /trunk/kdesupport/emerge/bin/Packager/NullsoftInstallerPackager.py (1214807)
  • /trunk/kdesupport/emerge/bin/Source/ArchiveSource.py (1214807)
  • /trunk/kdesupport/emerge/bin/Source/FileSource.py (1214807)
  • /trunk/kdesupport/emerge/bin/Source/SourceBase.py (1214807)

View Diff
--===============1130161191010904904==-- --===============0930914402== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows --===============0930914402==--