[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-utils-devel
Subject: Re: Review Request: Fix example cli plugin
From: "Raphael Kubo da Costa" <rakuco () freebsd ! org>
Date: 2011-10-11 13:04:07
Message-ID: 20111011130407.9606.61978 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102784/#review7246
-----------------------------------------------------------
Thanks for the patch. I think we can improve it even further by splitting t=
he class into a .h file and a .cpp file.
plugins/cliplugin/cliplugin.cpp
<http://git.reviewboard.kde.org/r/102784/#comment6306>
Please #include "kerfuffle/kerfuffle_export.h" explicitly to use this m=
acro.
- Raphael Kubo da Costa
On Oct. 5, 2011, 2:21 p.m., Theofilos Intzoglou wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102784/
> -----------------------------------------------------------
> =
> (Updated Oct. 5, 2011, 2:21 p.m.)
> =
> =
> Review request for KDE Utils and Raphael Kubo da Costa.
> =
> =
> Description
> -------
> =
> The example cli plugin needed some changes to be usable due to changes to=
the way the ark handles its plugins
> =
> =
> Diffs
> -----
> =
> plugins/cliplugin/cliplugin.cpp e46853f =
> =
> Diff: http://git.reviewboard.kde.org/r/102784/diff/diff
> =
> =
> Testing
> -------
> =
> Now the cliplugin is compilable without any warnings
> =
> =
> Thanks,
> =
> Theofilos Intzoglou
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102784/">http://git.reviewboard.kde.org/r/102784/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for the patch. I think we can improve \
it even further by splitting the class into a .h file and a .cpp file.</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; \
padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/102784/diff/1/?file=37913#file37913line147" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plugins/cliplugin/cliplugin.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">KERFUFFLE_PLUGIN_FACTORY(CliPlugin)</pre></td> <td colspan="2"><pre style="font-size: 8pt; \
line-height: 140%; margin: 0; ">KERFUFFLE_EXPORT_PLUGIN(CliPlugin)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">145</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; \
line-height: 140%; margin: 0; "><span class="n">KERFUFFLE_PLUGIN<span \
class="hl">_FACTORY</span></span><span class="p">(</span><span class="n">CliPlugin</span><span \
class="p">)</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; \
border-right: 1px solid #C0C0C0;" align="right"><font size="2">146</font></th> <td \
bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="n">KERFUFFLE_<span class="hl">EXPORT_</span>PLUGIN</span><span class="p">(</span><span \
class="n">CliPlugin</span><span class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please #include \
"kerfuffle/kerfuffle_export.h" explicitly to use this macro.</pre> </div>
<br />
<p>- Raphael</p>
<br />
<p>On October 5th, 2011, 2:21 p.m., Theofilos Intzoglou wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for KDE Utils and Raphael Kubo da Costa.</div>
<div>By Theofilos Intzoglou.</div>
<p style="color: grey;"><i>Updated Oct. 5, 2011, 2:21 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The example cli \
plugin needed some changes to be usable due to changes to the way the ark handles its \
plugins</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Now the cliplugin is \
compilable without any warnings</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/cliplugin/cliplugin.cpp <span style="color: grey">(e46853f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102784/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-utils-devel mailing list
Kde-utils-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-utils-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic