This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102784/

Thanks for the patch. I think we can improve it even further by splitting the class into a .h file and a .cpp file.

plugins/cliplugin/cliplugin.cpp (Diff revision 1)
KERFUFFLE_PLUGIN_FACTORY(CliPlugin)		KERFUFFLE_EXPORT_PLUGIN(CliPlugin)
145	KERFUFFLE_PLUGIN_FACTORY(CliPlugin)	146	KERFUFFLE_EXPORT_PLUGIN(CliPlugin)

Please #include "kerfuffle/kerfuffle_export.h" explicitly to use this macro.

- Raphael

On October 5th, 2011, 2:21 p.m., Theofilos Intzoglou wrote:

Review request for KDE Utils and Raphael Kubo da Costa.

By Theofilos Intzoglou.

Updated Oct. 5, 2011, 2:21 p.m.

Description

The example cli plugin needed some changes to be usable due to changes to the way the ark handles its plugins

Testing

Now the cliplugin is compilable without any warnings