--===============2523597427583960817== Content-Type: multipart/alternative; boundary="===============6884797927473931041==" --===============6884797927473931041== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102784/#review7246 ----------------------------------------------------------- Thanks for the patch. I think we can improve it even further by splitting t= he class into a .h file and a .cpp file. plugins/cliplugin/cliplugin.cpp Please #include "kerfuffle/kerfuffle_export.h" explicitly to use this m= acro. - Raphael Kubo da Costa On Oct. 5, 2011, 2:21 p.m., Theofilos Intzoglou wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102784/ > ----------------------------------------------------------- > = > (Updated Oct. 5, 2011, 2:21 p.m.) > = > = > Review request for KDE Utils and Raphael Kubo da Costa. > = > = > Description > ------- > = > The example cli plugin needed some changes to be usable due to changes to= the way the ark handles its plugins > = > = > Diffs > ----- > = > plugins/cliplugin/cliplugin.cpp e46853f = > = > Diff: http://git.reviewboard.kde.org/r/102784/diff/diff > = > = > Testing > ------- > = > Now the cliplugin is compilable without any warnings > = > = > Thanks, > = > Theofilos Intzoglou > = > --===============6884797927473931041== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/102784/

Thanks for=
 the patch. I think we can improve it even further by splitting the class i=
nto a .h file and a .cpp file.

= =

plugins/cliplugin/cliplugin.cpp (Diff revision 1)
KERFUFFLE_PLUGIN_FACTORY(CliPlugin)	KERFUFFLE_EXPORT_PLUGIN(CliPlugin)
145	KERFUFFLE_PLUGIN_FACTORY(C= liPlugin)	146	KERFUFFLE_EXPORT_PLUGIN(Cli= Plugin)

Please #include "kerfuffle/kerfuffle_export.h" explicitly =
to use this macro.

- Raphael

On October 5th, 2011, 2:21 p.m., Theofilos Intzoglou wrote:

Review request for KDE Utils and Raphael Kubo da Costa.

By Theofilos Intzoglou.

Updated Oct. 5, 2011, 2:21 p.m.

Descripti= on

The example cli plugin needed some changes to be usable due =
to changes to the way the ark handles its plugins

Testing <= /h1>

Now the cliplugin is compilable without any warnings

Diffs=

plugins/cliplugin/cliplugin.cpp (e46853f)<= /span>

View Diff

--===============6884797927473931041==-- --===============2523597427583960817== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Kde-utils-devel mailing list Kde-utils-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-utils-devel --===============2523597427583960817==--