[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-usability
Subject:    Re: [KDE Usability] Review Request 127046: Move popup menu image actions into a submenu
From:       Thomas Pfeiffer <colomar () autistici ! org>
Date:       2016-02-12 14:37:48
Message-ID: 20160212143748.7653.55456 () mimi ! kde ! org
[Download RAW message or body]

--===============5342109235594821567==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127046/#review92299
-----------------------------------------------------------



I wouldn't say that all actions for images are rarely used.
I don't see why viewing, copying or saving an image is less frequently done than the \
same things regarding the link. Can't we have those three still on the first level \
and then a "More..." option with further actions?

- Thomas Pfeiffer


On Feb. 11, 2016, 6:18 p.m., Jonathan Marten wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127046/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2016, 6:18 p.m.)
> 
> 
> Review request for KDE Frameworks and KDE Usability.
> 
> 
> Repository: khtml
> 
> 
> Description
> -------
> 
> The popup menu over an image (with actions "Save Image As..." etcetera, see screen \
> shot) has in total 6 image actions which are not frequently used but make the menu \
> very long.  Moving these actions onto a submenu makes the top level menu smaller \
> and more logically grouped. 
> 
> Diffs
> -----
> 
> src/khtml_ext.cpp 0f522f4 
> 
> Diff: https://git.reviewboard.kde.org/r/127046/diff/
> 
> 
> Testing
> -------
> 
> Built KHTML with these changes, tested in Konqueror.
> 
> 
> File Attachments
> ----------------
> 
> Popup menu before
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/11/55c12311-73a3-472a-8a9a-6b6b9fce9de7__before.png
>  Popup menu after
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/11/313dbe3b-efb4-475c-bf76-8516f5bc85b4__after.png
>  
> 
> Thanks,
> 
> Jonathan Marten
> 
> 


--===============5342109235594821567==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/127046/">https://git.reviewboard.kde.org/r/127046/</a>
  </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
wouldn't say that all actions for images are rarely used. I don't see why viewing, \
copying or saving an image is less frequently done than the same things regarding the \
link. Can't we have those three still on the first level and then a "More..." option \
with further actions?</p></pre>  <br />









<p>- Thomas Pfeiffer</p>


<br />
<p>On February 11th, 2016, 6:18 p.m. UTC, Jonathan Marten wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks and KDE Usability.</div>
<div>By Jonathan Marten.</div>


<p style="color: grey;"><i>Updated Feb. 11, 2016, 6:18 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
khtml
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The popup menu over an image (with actions &quot;Save Image As...&quot; \
etcetera, see screen shot) has in total 6 image actions which are not frequently used \
but make the menu very long.  Moving these actions onto a submenu makes the top level \
menu smaller and more logically grouped.</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Built KHTML with these changes, tested in Konqueror.</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/khtml_ext.cpp <span style="color: grey">(0f522f4)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/127046/diff/" style="margin-left: \
3em;">View Diff</a></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>


 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/02/11/55c12311-73a3-472a-8a9a-6b6b9fce9de7__before.png">Popup \
menu before</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/02/11/313dbe3b-efb4-475c-bf76-8516f5bc85b4__after.png">Popup \
menu after</a></li>

</ul>




  </td>
 </tr>
</table>







  </div>
 </body>
</html>


--===============5342109235594821567==--


[Attachment #3 (text/plain)]

_______________________________________________
kde-usability mailing list
kde-usability@kde.org
https://mail.kde.org/mailman/listinfo/kde-usability


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic