From kde-usability Fri Feb 12 14:37:48 2016 From: Thomas Pfeiffer Date: Fri, 12 Feb 2016 14:37:48 +0000 To: kde-usability Subject: Re: [KDE Usability] Review Request 127046: Move popup menu image actions into a submenu Message-Id: <20160212143748.7653.55456 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-usability&m=145528789517376 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1620877642836761817==" --===============1620877642836761817== Content-Type: multipart/alternative; boundary="===============5342109235594821567==" --===============5342109235594821567== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127046/#review92299 ----------------------------------------------------------- I wouldn't say that all actions for images are rarely used. I don't see why viewing, copying or saving an image is less frequently done than the same things regarding the link. Can't we have those three still on the first level and then a "More..." option with further actions? - Thomas Pfeiffer On Feb. 11, 2016, 6:18 p.m., Jonathan Marten wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127046/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2016, 6:18 p.m.) > > > Review request for KDE Frameworks and KDE Usability. > > > Repository: khtml > > > Description > ------- > > The popup menu over an image (with actions "Save Image As..." etcetera, see screen shot) has in total 6 image actions which are not frequently used but make the menu very long. Moving these actions onto a submenu makes the top level menu smaller and more logically grouped. > > > Diffs > ----- > > src/khtml_ext.cpp 0f522f4 > > Diff: https://git.reviewboard.kde.org/r/127046/diff/ > > > Testing > ------- > > Built KHTML with these changes, tested in Konqueror. > > > File Attachments > ---------------- > > Popup menu before > https://git.reviewboard.kde.org/media/uploaded/files/2016/02/11/55c12311-73a3-472a-8a9a-6b6b9fce9de7__before.png > Popup menu after > https://git.reviewboard.kde.org/media/uploaded/files/2016/02/11/313dbe3b-efb4-475c-bf76-8516f5bc85b4__after.png > > > Thanks, > > Jonathan Marten > > --===============5342109235594821567== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127046/ 

I wouldn't say that all actions for images are rarely used.
I don't see why viewing, copying or saving an image is less frequently done than the same things regarding the link. Can't we have those three still on the first level and then a "More..." option with further actions?

- Thomas Pfeiffer


On February 11th, 2016, 6:18 p.m. UTC, Jonathan Marten wrote:

Review request for KDE Frameworks and KDE Usability.
By Jonathan Marten.

Updated Feb. 11, 2016, 6:18 p.m.

Repository: khtml

Description 

The popup menu over an image (with actions "Save Image As..." etcetera, see screen shot) has in total 6 image actions which are not frequently used but make the menu very long.  Moving these actions onto a submenu makes the top level menu smaller and more logically grouped.

Testing 

Built KHTML with these changes, tested in Konqueror.

Diffs

  • src/khtml_ext.cpp (0f522f4)

View Diff

File Attachments

  • Popup menu before
  • Popup menu after
    		•
    --===============5342109235594821567==-- --===============1620877642836761817== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18Ka2RlLXVzYWJp bGl0eSBtYWlsaW5nIGxpc3QKa2RlLXVzYWJpbGl0eUBrZGUub3JnCmh0dHBzOi8vbWFpbC5rZGUu b3JnL21haWxtYW4vbGlzdGluZm8va2RlLXVzYWJpbGl0eQo= --===============1620877642836761817==--