[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-usability
Subject: [KDE Usability] Review Request 127046: Move popup menu image actions into a submenu
From: Jonathan Marten <jjm () keelhaul ! me ! uk>
Date: 2016-02-11 18:18:01
Message-ID: 20160211181801.7653.11079 () mimi ! kde ! org
[Download RAW message or body]
--===============1201637154920486014==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127046/
-----------------------------------------------------------
Review request for KDE Frameworks and KDE Usability.
Repository: khtml
Description
-------
The popup menu over an image (with actions "Save Image As..." etcetera, see screen \
shot) has in total 6 image actions which are not frequently used but make the menu \
very long. Moving these actions onto a submenu makes the top level menu smaller and \
more logically grouped.
Diffs
-----
src/khtml_ext.cpp 0f522f4
Diff: https://git.reviewboard.kde.org/r/127046/diff/
Testing
-------
Built KHTML with these changes, tested in Konqueror.
File Attachments
----------------
Popup menu before
https://git.reviewboard.kde.org/media/uploaded/files/2016/02/11/55c12311-73a3-472a-8a9a-6b6b9fce9de7__before.png
Popup menu after
https://git.reviewboard.kde.org/media/uploaded/files/2016/02/11/313dbe3b-efb4-475c-bf76-8516f5bc85b4__after.png
Thanks,
Jonathan Marten
--===============1201637154920486014==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127046/">https://git.reviewboard.kde.org/r/127046/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and KDE Usability.</div>
<div>By Jonathan Marten.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
khtml
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The popup menu over an image (with actions "Save Image As..." \
etcetera, see screen shot) has in total 6 image actions which are not frequently used \
but make the menu very long. Moving these actions onto a submenu makes the top level \
menu smaller and more logically grouped.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Built KHTML with these changes, tested in Konqueror.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/khtml_ext.cpp <span style="color: grey">(0f522f4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127046/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/02/11/55c12311-73a3-472a-8a9a-6b6b9fce9de7__before.png">Popup \
menu before</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/02/11/313dbe3b-efb4-475c-bf76-8516f5bc85b4__after.png">Popup \
menu after</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1201637154920486014==--
[Attachment #3 (text/plain)]
_______________________________________________
kde-usability mailing list
kde-usability@kde.org
https://mail.kde.org/mailman/listinfo/kde-usability
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic