'Re: Centering of text body in tips of the day?'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-usability
Subject:    Re: Centering of text body in tips of the day?
From:       Aurélien_Gâteau <aurelien.gateau () free ! fr>
Date:       2008-12-23 22:18:46
Message-ID: 495163C6.60604 () free ! fr
[Download RAW message or body]

Celeste Lyn Paul wrote:

>> As I've commented in the report, we could add a switch for translators to
>> disable centering, but I'm wondering if the issue is really language
>> specific. Is it not bad for the readability of even the English text to be
>> centered?
> 
> Yes, and there was a bit of discussion about this a while ago.  I forget why 
> it never got fixed to being left aligned, maybe the maintainer didn't agree and 
> so didn't do it.  It should be changed.
> 
Attached simple patch fix this. If no one objects I'll commit it.

Aurélien

["0001-Do-not-center-text-in-tipdialog.diff" (text/x-diff)]

From fe429e3fcd6e0e6e40767f32929020f803a44e16 Mon Sep 17 00:00:00 2001
From: =?utf-8?q?AurÃ©lien GÃ¢teau?= <aurelien@trinity.(none)>
Date: Tue, 23 Dec 2008 23:15:59 +0100
Subject: [PATCH] Do not center text in tipdialog.

---
 kdeui/dialogs/ktip.cpp |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/kdeui/dialogs/ktip.cpp b/kdeui/dialogs/ktip.cpp
index 4686a3d..bf190d0 100644
--- a/kdeui/dialogs/ktip.cpp
+++ b/kdeui/dialogs/ktip.cpp
@@ -201,14 +201,14 @@ KTipDialog *KTipDialog::Private::mInstance = 0;
 void KTipDialog::Private::_k_prevTip()
 {
   database->prevTip();
-  tipText->setHtml( QString::fromLatin1( "<html><center>%1</center></html>" )
+  tipText->setHtml( QString::fromLatin1( "<html><body>%1</body></html>" )
                   .arg( i18n( database->tip().toUtf8() ) ) );
 }

 void KTipDialog::Private::_k_nextTip()
 {
   database->nextTip();
-  tipText->setHtml( QString::fromLatin1( "<html><center>%1</center></html>" )
+  tipText->setHtml( QString::fromLatin1( "<html><body>%1</body></html>" )
                   .arg( i18n( database->tip().toUtf8() ) ) );
 }

--
1.5.4.4



_______________________________________________
kde-usability mailing list
kde-usability@kde.org
https://mail.kde.org/mailman/listinfo/kde-usability


[prev in list] [next in list] [prev in thread] [next in thread] 
