[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-telepathy
Subject: Re: Review Request 127005: Port to QWebEngine
From: Martin Klapetek <martin.klapetek () gmail ! com>
Date: 2017-03-04 15:51:10
Message-ID: 20170304155110.6511.41996 () mimi ! kde ! org
[Download RAW message or body]
--===============0859354308077100360==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Feb. 13, 2017, 12:18 a.m., Aleix Pol Gonzalez wrote:
> > +1 LGTM.
> >
> > Yes, QtWebEngine is an acceptable dependency.
>
> Niels Ole Salscheider wrote:
> That's good to hear.
>
> Does anybody feel like giving me a "Ship it" or is there something left that I \
> should fix? I've been using this for months and I didn't notice any problems...
I'll have the packagers sign off this. If nobody objects in a week, consider this a \
ship it.
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127005/#review102519
-----------------------------------------------------------
On Feb. 11, 2017, 7:32 p.m., Niels Ole Salscheider wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127005/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2017, 7:32 p.m.)
>
>
> Review request for Telepathy.
>
>
> Repository: ktp-text-ui
>
>
> Description
> -------
>
> This ports the message viewer from QWebKit to QWebEngine.
>
>
> Diffs
> -----
>
> CMakeLists.txt 86aa80a
> adiumxtra-protocol-handler/CMakeLists.txt f78a62f
> app/CMakeLists.txt 9a90cec
> config/appearance/CMakeLists.txt dfb5d04
> config/appearance/appearance-config-tab.cpp f2f298b
> lib/CMakeLists.txt 5294521
> lib/adium-theme-view.h 5a0c2e6
> lib/adium-theme-view.cpp d1c93f4
> lib/chat-search-bar.h c8c5118
> lib/chat-search-bar.cpp 484975a
> lib/chat-widget.h 588407c
> lib/chat-widget.cpp fdc9c1e
> logviewer/CMakeLists.txt c36157c
> logviewer/log-viewer.cpp b1dad26
> logviewer/message-view.h ec592c7
> logviewer/message-view.cpp 1b3bbe4
>
> Diff: https://git.reviewboard.kde.org/r/127005/diff/
>
>
> Testing
> -------
>
> - Builds
> - Chats with the text UI work
> - Links work
> - The log viewer works
>
>
> Thanks,
>
> Niels Ole Salscheider
>
>
--===============0859354308077100360==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127005/">https://git.reviewboard.kde.org/r/127005/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 13th, 2017, 12:18 a.m. CET, <b>Aleix \
Pol Gonzalez</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">+1 LGTM.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes, QtWebEngine is an \
acceptable dependency.</p></pre> </blockquote>
<p>On March 4th, 2017, 10:58 a.m. CET, <b>Niels Ole Salscheider</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">That's good to hear.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Does anybody feel like \
giving me a "Ship it" or is there something left that I should fix? I've been using \
this for months and I didn't notice any problems...</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'll \
have the packagers sign off this. If nobody objects in a week, consider this a ship \
it.</p></pre> <br />
<p>- Martin</p>
<br />
<p>On February 11th, 2017, 7:32 p.m. CET, Niels Ole Salscheider wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Niels Ole Salscheider.</div>
<p style="color: grey;"><i>Updated Feb. 11, 2017, 7:32 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-text-ui
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This ports the message viewer from QWebKit to \
QWebEngine.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
1em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">Builds</li> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">Chats with the text UI work</li> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">Links work</li> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">The log viewer works</li> </ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(86aa80a)</span></li>
<li>adiumxtra-protocol-handler/CMakeLists.txt <span style="color: \
grey">(f78a62f)</span></li>
<li>app/CMakeLists.txt <span style="color: grey">(9a90cec)</span></li>
<li>config/appearance/CMakeLists.txt <span style="color: grey">(dfb5d04)</span></li>
<li>config/appearance/appearance-config-tab.cpp <span style="color: \
grey">(f2f298b)</span></li>
<li>lib/CMakeLists.txt <span style="color: grey">(5294521)</span></li>
<li>lib/adium-theme-view.h <span style="color: grey">(5a0c2e6)</span></li>
<li>lib/adium-theme-view.cpp <span style="color: grey">(d1c93f4)</span></li>
<li>lib/chat-search-bar.h <span style="color: grey">(c8c5118)</span></li>
<li>lib/chat-search-bar.cpp <span style="color: grey">(484975a)</span></li>
<li>lib/chat-widget.h <span style="color: grey">(588407c)</span></li>
<li>lib/chat-widget.cpp <span style="color: grey">(fdc9c1e)</span></li>
<li>logviewer/CMakeLists.txt <span style="color: grey">(c36157c)</span></li>
<li>logviewer/log-viewer.cpp <span style="color: grey">(b1dad26)</span></li>
<li>logviewer/message-view.h <span style="color: grey">(ec592c7)</span></li>
<li>logviewer/message-view.cpp <span style="color: grey">(1b3bbe4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127005/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0859354308077100360==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic