[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-telepathy
Subject: Re: Review Request 127005: Port to QWebEngine
From: Niels Ole Salscheider <niels_ole () salscheider-online ! de>
Date: 2017-03-13 19:19:23
Message-ID: 20170313191923.8720.47166 () mimi ! kde ! org
[Download RAW message or body]
--===============1550253736787039715==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127005/
-----------------------------------------------------------
(Updated March 13, 2017, 1:19 p.m.)
Status
------
This change has been marked as submitted.
Review request for Telepathy.
Changes
-------
Submitted with commit 06f9110dd1f4fdc8552d48ed3d10277d4e44a152 by Niels Ole \
Salscheider to branch master.
Repository: ktp-text-ui
Description
-------
This ports the message viewer from QWebKit to QWebEngine.
Diffs
-----
CMakeLists.txt 86aa80a
adiumxtra-protocol-handler/CMakeLists.txt f78a62f
app/CMakeLists.txt 9a90cec
config/appearance/CMakeLists.txt dfb5d04
config/appearance/appearance-config-tab.cpp f2f298b
lib/CMakeLists.txt 5294521
lib/adium-theme-view.h 5a0c2e6
lib/adium-theme-view.cpp d1c93f4
lib/chat-search-bar.h c8c5118
lib/chat-search-bar.cpp 484975a
lib/chat-widget.h 588407c
lib/chat-widget.cpp fdc9c1e
logviewer/CMakeLists.txt c36157c
logviewer/log-viewer.cpp b1dad26
logviewer/message-view.h ec592c7
logviewer/message-view.cpp 1b3bbe4
Diff: https://git.reviewboard.kde.org/r/127005/diff/
Testing
-------
- Builds
- Chats with the text UI work
- Links work
- The log viewer works
Thanks,
Niels Ole Salscheider
--===============1550253736787039715==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127005/">https://git.reviewboard.kde.org/r/127005/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Niels Ole Salscheider.</div>
<p style="color: grey;"><i>Updated March 13, 2017, 1:19 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 06f9110dd1f4fdc8552d48ed3d10277d4e44a152 by Niels \
Ole Salscheider to branch master.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-text-ui
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This ports the message viewer from QWebKit to \
QWebEngine.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
1em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">Builds</li> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">Chats with the text UI work</li> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">Links work</li> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">The log viewer works</li> </ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(86aa80a)</span></li>
<li>adiumxtra-protocol-handler/CMakeLists.txt <span style="color: \
grey">(f78a62f)</span></li>
<li>app/CMakeLists.txt <span style="color: grey">(9a90cec)</span></li>
<li>config/appearance/CMakeLists.txt <span style="color: grey">(dfb5d04)</span></li>
<li>config/appearance/appearance-config-tab.cpp <span style="color: \
grey">(f2f298b)</span></li>
<li>lib/CMakeLists.txt <span style="color: grey">(5294521)</span></li>
<li>lib/adium-theme-view.h <span style="color: grey">(5a0c2e6)</span></li>
<li>lib/adium-theme-view.cpp <span style="color: grey">(d1c93f4)</span></li>
<li>lib/chat-search-bar.h <span style="color: grey">(c8c5118)</span></li>
<li>lib/chat-search-bar.cpp <span style="color: grey">(484975a)</span></li>
<li>lib/chat-widget.h <span style="color: grey">(588407c)</span></li>
<li>lib/chat-widget.cpp <span style="color: grey">(fdc9c1e)</span></li>
<li>logviewer/CMakeLists.txt <span style="color: grey">(c36157c)</span></li>
<li>logviewer/log-viewer.cpp <span style="color: grey">(b1dad26)</span></li>
<li>logviewer/message-view.h <span style="color: grey">(ec592c7)</span></li>
<li>logviewer/message-view.cpp <span style="color: grey">(1b3bbe4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127005/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1550253736787039715==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic