From kde-telepathy Sat Mar 04 15:51:10 2017 From: Martin Klapetek Date: Sat, 04 Mar 2017 15:51:10 +0000 To: kde-telepathy Subject: Re: Review Request 127005: Port to QWebEngine Message-Id: <20170304155110.6511.41996 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-telepathy&m=148864267913692 --===============0859354308077100360== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Feb. 13, 2017, 12:18 a.m., Aleix Pol Gonzalez wrote: > > +1 LGTM. > > > > Yes, QtWebEngine is an acceptable dependency. > > Niels Ole Salscheider wrote: > That's good to hear. > > Does anybody feel like giving me a "Ship it" or is there something left that I should fix? > I've been using this for months and I didn't notice any problems... I'll have the packagers sign off this. If nobody objects in a week, consider this a ship it. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127005/#review102519 ----------------------------------------------------------- On Feb. 11, 2017, 7:32 p.m., Niels Ole Salscheider wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127005/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2017, 7:32 p.m.) > > > Review request for Telepathy. > > > Repository: ktp-text-ui > > > Description > ------- > > This ports the message viewer from QWebKit to QWebEngine. > > > Diffs > ----- > > CMakeLists.txt 86aa80a > adiumxtra-protocol-handler/CMakeLists.txt f78a62f > app/CMakeLists.txt 9a90cec > config/appearance/CMakeLists.txt dfb5d04 > config/appearance/appearance-config-tab.cpp f2f298b > lib/CMakeLists.txt 5294521 > lib/adium-theme-view.h 5a0c2e6 > lib/adium-theme-view.cpp d1c93f4 > lib/chat-search-bar.h c8c5118 > lib/chat-search-bar.cpp 484975a > lib/chat-widget.h 588407c > lib/chat-widget.cpp fdc9c1e > logviewer/CMakeLists.txt c36157c > logviewer/log-viewer.cpp b1dad26 > logviewer/message-view.h ec592c7 > logviewer/message-view.cpp 1b3bbe4 > > Diff: https://git.reviewboard.kde.org/r/127005/diff/ > > > Testing > ------- > > - Builds > - Chats with the text UI work > - Links work > - The log viewer works > > > Thanks, > > Niels Ole Salscheider > > --===============0859354308077100360== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127005/

On February 13th, 2017, 12:18 a.m. CET, Aleix Pol Gonzalez wrote:
+1 LGTM.
Yes, QtWebEngine is an acceptable dependency.
On March 4th, 2017, 10:58 a.m. CET, Niels Ole Salscheider wrote:
That's good to hear.
Does anybody feel like giving me a "Ship it" or is there something left that I should fix?
I've been using this for months and I didn't notice any problems...

I'll have the packagers sign off this. If nobody objects in a week, consider this a ship it.

- Martin

On February 11th, 2017, 7:32 p.m. CET, Niels Ole Salscheider wrote:

Review request for Telepathy.

By Niels Ole Salscheider.

Updated Feb. 11, 2017, 7:32 p.m.

Repository: ktp-text-ui

Description

This ports the message viewer from QWebKit to QWebEngine.

Testing


Builds
Chats with the text UI work
Links work
The log viewer works

Diffs

CMakeLists.txt (86aa80a)
adiumxtra-protocol-handler/CMakeLists.txt (f78a62f)
app/CMakeLists.txt (9a90cec)
config/appearance/CMakeLists.txt (dfb5d04)
config/appearance/appearance-config-tab.cpp (f2f298b)
lib/CMakeLists.txt (5294521)
lib/adium-theme-view.h (5a0c2e6)
lib/adium-theme-view.cpp (d1c93f4)
lib/chat-search-bar.h (c8c5118)
lib/chat-search-bar.cpp (484975a)
lib/chat-widget.h (588407c)
lib/chat-widget.cpp (fdc9c1e)
logviewer/CMakeLists.txt (c36157c)
logviewer/log-viewer.cpp (b1dad26)
logviewer/message-view.h (ec592c7)
logviewer/message-view.cpp (1b3bbe4)

--===============0859354308077100360==--