[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-telepathy
Subject: Re: Review Request 126834: ktp-common-internals propagating presence model
From: David Edmundson <david () davidedmundson ! co ! uk>
Date: 2016-03-13 23:08:30
Message-ID: 20160313230830.22520.24414 () mimi ! kde ! org
[Download RAW message or body]
--===============8726435067990531111==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126834/#review93493
-----------------------------------------------------------
General approach seems like a good idea.
You have one big bug in here (comment #2).
KTp/Models/presence-model.cpp (line 85)
<https://git.reviewboard.kde.org/r/126834/#comment63745>
you should be able to have
presenceModelChanged(KTp::Presence, bool)
and have it automatically cast as long as you have registered KTp::Presence as a \
DBus type
KTp/Models/presence-model.cpp (line 184)
<https://git.reviewboard.kde.org/r/126834/#comment63747>
on the initial load we call addPresence; addPresence is emitting DBus signals to \
all the other clients when it's not actually adding anything, but just loading the \
existing ones which all the other clients should already have.
It won't break as the other clients won't do anything, but it's rather wasteful.
KTp/Models/presence-model.cpp (line 230)
<https://git.reviewboard.kde.org/r/126834/#comment63746>
Personally I'd use two different DBus signals for add/remove.
- David Edmundson
On Feb. 23, 2016, 7:16 a.m., James Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126834/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2016, 7:16 a.m.)
>
>
> Review request for Telepathy.
>
>
> Repository: ktp-common-internals
>
>
> Description
> -------
>
> New features:
> -Simplified API, sends and collects changes over DBus.
>
>
> Diffs
> -----
>
> KTp/Models/presence-model.h 8f206b880f48640626322269a14956f105482f69
> KTp/Models/presence-model.cpp ddc1a7c75f1a452bf3ac2db1aecbd88a5d1ce519
>
> Diff: https://git.reviewboard.kde.org/r/126834/diff/
>
>
> Testing
> -------
>
> Compile, run.
>
>
> Thanks,
>
> James Smith
>
>
--===============8726435067990531111==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126834/">https://git.reviewboard.kde.org/r/126834/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">General approach seems like a good idea.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You \
have one big bug in here (comment #2).</p></pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/126834/diff/2/?file=445116#file445116line86" \
style="color: black; font-weight: bold; text-decoration: \
underline;">KTp/Models/presence-model.cpp</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">85</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="kt">void</span> <span class="n">PresenceModel</span><span \
class="o">::</span><span class="n">presenceModelChanged</span><span \
class="p">(</span><span class="n">QVariantList</span> <span \
class="n">modelChanges</span><span class="p">)</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">you \
should be able to have presenceModelChanged(KTp::Presence, bool)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">and have it automatically cast as long as you have \
registered KTp::Presence as a DBus type</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/126834/diff/2/?file=445116#file445116line185" \
style="color: black; font-weight: bold; text-decoration: \
underline;">KTp/Models/presence-model.cpp</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">QModelIndex PresenceModel::addPresence(const KTp::Presence \
&presence)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">163</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">addPresence</span><span class="p">(</span><span class="n">KTp</span><span \
class="o">::</span><span class="n">Presence</span><span class="o">::</span><span \
class="n">available</span><span class="p">(</span><span \
class="n">statusMessage</span><span class="p">));</span></pre></td> <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">184</font></th> <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">addPresence</span><span class="p">(</span><span \
class="n">KTp</span><span class="o">::</span><span class="n">Presence</span><span \
class="o">::</span><span class="n">available</span><span class="p">(</span><span \
class="n">statusMessage</span><span class="p">));</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">on \
the initial load we call addPresence; addPresence is emitting DBus signals to all the \
other clients when it's not actually adding anything, but just loading the existing \
ones which all the other clients should already have.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It \
won't break as the other clients won't do anything, but it's rather \
wasteful.</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/126834/diff/2/?file=445116#file445116line231" \
style="color: black; font-weight: bold; text-decoration: \
underline;">KTp/Models/presence-model.cpp</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">203</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt">int</span> \
<span class="n">PresenceModel</span><span class="o">::</span><span \
class="n">updatePresenceApplet</span><span class="p">()</span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">230</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="kt">void</span> <span class="n">PresenceModel</span><span \
class="o">::</span><span class="n">propagateNewPresenceChange</span><span \
class="p">(</span><span class="k">const</span> <span class="n">KTp</span><span \
class="o">::</span><span class="n">Presence</span> <span class="o">&</span><span \
class="n">presence</span><span class="p">,</span> <span class="kt">bool</span> <span \
class="n">addPresence</span><span class="p">)</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Personally I'd use two different DBus signals for add/remove.</p></pre> \
</div> </div>
<br />
<p>- David Edmundson</p>
<br />
<p>On February 23rd, 2016, 7:16 a.m. UTC, James Smith wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Telepathy.</div>
<div>By James Smith.</div>
<p style="color: grey;"><i>Updated Feb. 23, 2016, 7:16 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-common-internals
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">New features:
-Simplified API, sends and collects changes over DBus.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Compile, run.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KTp/Models/presence-model.h <span style="color: \
grey">(8f206b880f48640626322269a14956f105482f69)</span></li>
<li>KTp/Models/presence-model.cpp <span style="color: \
grey">(ddc1a7c75f1a452bf3ac2db1aecbd88a5d1ce519)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126834/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8726435067990531111==--
[Attachment #3 (text/plain)]
_______________________________________________
KDE-Telepathy mailing list
KDE-Telepathy@kde.org
https://mail.kde.org/mailman/listinfo/kde-telepathy
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic