'Re: Review Request 126834: ktp-common-internals propagating presence model'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-telepathy
Subject:    Re: Review Request 126834: ktp-common-internals propagating presence model
From:       David Edmundson <david () davidedmundson ! co ! uk>
Date:       2016-03-13 23:00:56
Message-ID: 20160313230056.22520.91618 () mimi ! kde ! org
[Download RAW message or body]

--===============4564128695332712267==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

> On Feb. 29, 2016, 7:56 p.m., Martin Klapetek wrote:
> > Can you please be more specific with your descriptions? I have no clue what's the \
> > point of this change or what is it supposed to do/fix/prevent.

I can explain this one at least. 

I'll write it here to show what I need to see in a description:

The current code stores custom presences in a config file then sends a signal \
explicitly to the presence applet to reparse the config file.

This isn't ideal because:
 - the presence applet doesn't write back into the contact list
 - we would have duplicate code if it did 
 - we need read/write from krunner as well now that also has presence message support

This code moves the propogating changes to be internal to the model shared by all the \
components with add/remove signals for the new messages.

- David

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126834/#review92932
-----------------------------------------------------------

On Feb. 23, 2016, 7:16 a.m., James Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126834/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2016, 7:16 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> New features:
> -Simplified API, sends and collects changes over DBus.
> 
> 
> Diffs
> -----
> 
> KTp/Models/presence-model.h 8f206b880f48640626322269a14956f105482f69 
> KTp/Models/presence-model.cpp ddc1a7c75f1a452bf3ac2db1aecbd88a5d1ce519 
> 
> Diff: https://git.reviewboard.kde.org/r/126834/diff/
> 
> 
> Testing
> -------
> 
> Compile, run.
> 
> 
> Thanks,
> 
> James Smith
> 
> 

--===============4564128695332712267==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126834/">https://git.reviewboard.kde.org/r/126834/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On February 29th, 2016, 7:56 p.m. UTC, <b>Martin \
Klapetek</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Can you please be more specific with your \
descriptions? I have no clue what's the point of this change or what is it supposed \
to do/fix/prevent.</p></pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I can \
explain this one at least. </p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">I'll write it here to show what I need \
to see in a description:</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">The current code stores custom \
presences in a config file then sends a signal explicitly to the presence applet to \
reparse the config file.</p> <p style="padding: 0;text-rendering: inherit;margin: \
                0;line-height: inherit;white-space: inherit;">This isn't ideal \
                because:
 - the presence applet doesn't write back into the contact list
 - we would have duplicate code if it did 
 - we need read/write from krunner as well now that also has presence message \
support</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This code moves the propogating changes to be internal \
to the model shared by all the components with add/remove signals for the new \
messages.</p></pre> <br />

<p>- David</p>

<br />
<p>On February 23rd, 2016, 7:16 a.m. UTC, James Smith wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Telepathy.</div>
<div>By James Smith.</div>

<p style="color: grey;"><i>Updated Feb. 23, 2016, 7:16 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-common-internals
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
                inherit;white-space: inherit;">New features:
-Simplified API, sends and collects changes over DBus.</p></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Compile, run.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>KTp/Models/presence-model.h <span style="color: \
grey">(8f206b880f48640626322269a14956f105482f69)</span></li>

 <li>KTp/Models/presence-model.cpp <span style="color: \
grey">(ddc1a7c75f1a452bf3ac2db1aecbd88a5d1ce519)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126834/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============4564128695332712267==--

[Attachment #3 (text/plain)]

_______________________________________________
KDE-Telepathy mailing list
KDE-Telepathy@kde.org
https://mail.kde.org/mailman/listinfo/kde-telepathy

[prev in list] [next in list] [prev in thread] [next in thread] 