'Re: Review Request 126834: ktp-common-internals propagating presence model'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-telepathy
Subject:    Re: Review Request 126834: ktp-common-internals propagating presence model
From:       James Smith <smithjd15 () gmail ! com>
Date:       2016-03-17 7:18:25
Message-ID: 20160317071825.10349.15290 () mimi ! kde ! org
[Download RAW message or body]

--===============4269190898171375378==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126834/
-----------------------------------------------------------

(Updated March 17, 2016, 7:18 a.m.)

Review request for Telepathy.

Changes
-------

1)Add a bool indicating the model has finished its initial load.
2)Stricter input checking in presenceModelChanged().
3)propagateNewPresenceChange -> propagateModelChange.
4)Minor debug capitalization change.
5)Const'ified presenceModelChanged QVariantList.

Repository: ktp-common-internals

Description
-------

New features:
-Simplified API, sends and collects changes over DBus.

Diffs (updated)
-----

  KTp/Models/presence-model.h 8f206b880f48640626322269a14956f105482f69 
  KTp/Models/presence-model.cpp ddc1a7c75f1a452bf3ac2db1aecbd88a5d1ce519 

Diff: https://git.reviewboard.kde.org/r/126834/diff/

Testing
-------

Compile, run.

Thanks,

James Smith

--===============4269190898171375378==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126834/">https://git.reviewboard.kde.org/r/126834/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Telepathy.</div>
<div>By James Smith.</div>

<p style="color: grey;"><i>Updated March 17, 2016, 7:18 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">1)Add a bool indicating the model has finished its initial load. \
2)Stricter input checking in presenceModelChanged(). 3)propagateNewPresenceChange \
-&gt; propagateModelChange. 4)Minor debug capitalization change.
5)Const&#39;ified presenceModelChanged QVariantList.</pre>
  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-common-internals
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
                inherit;white-space: inherit;">New features:
-Simplified API, sends and collects changes over DBus.</p></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Compile, run.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>KTp/Models/presence-model.h <span style="color: \
grey">(8f206b880f48640626322269a14956f105482f69)</span></li>

 <li>KTp/Models/presence-model.cpp <span style="color: \
grey">(ddc1a7c75f1a452bf3ac2db1aecbd88a5d1ce519)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126834/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============4269190898171375378==--

[Attachment #3 (text/plain)]

_______________________________________________
KDE-Telepathy mailing list
KDE-Telepathy@kde.org
https://mail.kde.org/mailman/listinfo/kde-telepathy

[prev in list] [next in list] [prev in thread] [next in thread] 