[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request 110221: Do not translate DavUtils::protocolName
From:       Grégory_Oestreicher <greg () kamago ! net>
Date:       2013-05-07 8:45:10
Message-ID: 20130507084510.11056.42337 () vidsolbach ! de
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110221/#review32183
-----------------------------------------------------------


Hi Yuri,

Thanks for this patch and for finding the root cause. Nice work!

I see two issues with this however:
- some strings that should be translated will no longer be (they're used in the UI);
- as you noticed the migration fails.

The first point should be resolvable by creating a new method that'll return the \
i18n'ed names and that gets called at the appropriate place(s). For the second a \
clean migration should be done when loading the settings, in settings.cpp. I'll have \
a look at this when some free time shows up and send you a patch for testing both \
cases. Note that this is by no mean a depreciation of your work and if you want to \
give those two issues a shot feel free to do it :)

Cheers,
Grégory

- Grégory Oestreicher


On May 6, 2013, 7:48 p.m., Yury Kudryashov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110221/
> -----------------------------------------------------------
> 
> (Updated May 6, 2013, 7:48 p.m.)
> 
> 
> Review request for KDEPIM and Grégory Oestreicher.
> 
> 
> Description
> -------
> 
> Do not translate DavUtils::protocolName
> 
> Dav resource assumes protocolName() to be untranslated in many places (e.g.,
> in protocolByName()).
> 
> 
> This addresses bug 298735.
> http://bugs.kde.org/show_bug.cgi?id=298735
> 
> 
> Diffs
> -----
> 
> resources/dav/common/davutils.h 48326213940ce156d877417a62e03e28ce50b67a 
> resources/dav/common/davutils.cpp 9a64f24d0bb86bab6ead871e72447578900d5695 
> 
> Diff: http://git.reviewboard.kde.org/r/110221/diff/
> 
> 
> Testing
> -------
> 
> 1. Works for new resources.
> 2. Doesn't work for old resources even after sed'ing the rc file. It seems that the \
> old (translated) string is hardcoded somewhere else (akonadi db?). 
> 
> Thanks,
> 
> Yury Kudryashov
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]