[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request: adds kmail support for RFC2369,
From:       Ingo_Klöcker <kloecker () kde ! org>
Date:       2009-10-22 15:48:40
Message-ID: 20091022154840.24634.88535 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1768/#review2767
-----------------------------------------------------------


As far as the icon is concerned I suggest to contact the KDE artists. For now it's \
probably better to omit the icon instead of using a wrong one.


/trunk/KDE/kdepim/kmail/messageactions.cpp
<http://reviewboard.kde.org/r/1768/#comment2098>

    Move this header to the other Qt header.



/trunk/KDE/kdepim/kmail/messageactions.cpp
<http://reviewboard.kde.org/r/1768/#comment2099>

    Move those KDE headers up to the other KDE headers. Also, please use #include \
<KRun> etc. instead of #include <krun.h>.



/trunk/KDE/kdepim/kmail/messageactions.cpp
<http://reviewboard.kde.org/r/1768/#comment2100>

    I suggest that you set the List-Id as title of the menu. Adding an action for the \
List-Id doesn't make much sense IMO. For one the user does not know which action you \
assigned to the List-ID action. Moreover, the action is also available below.



/trunk/KDE/kdepim/kmail/messageactions.cpp
<http://reviewboard.kde.org/r/1768/#comment2101>

    i18n() is missing. Also for all other actions.
    
    Moreover, I'd use "Go to Archive" (or similar) instead.



/trunk/KDE/kdepim/kmail/messageactions.cpp
<http://reviewboard.kde.org/r/1768/#comment2102>

    i18n() is missing.
    
    Also I'd use "Post New Message" instead.



/trunk/KDE/kdepim/kmail/messageactions.cpp
<http://reviewboard.kde.org/r/1768/#comment2103>

    See above. Aren't List-Archive and Archive-At equivalent? Does it make sense to \
list both?  



/trunk/KDE/kdepim/kmail/messageactions.cpp
<http://reviewboard.kde.org/r/1768/#comment2104>

    i18n()
    
    Probably better say "Request Help"?



/trunk/KDE/kdepim/kmail/messageactions.cpp
<http://reviewboard.kde.org/r/1768/#comment2105>

    const QVariant q = urlaction->data();
    
    Use const whenever possible.


- Ingo


On 2009-10-22 14:37:57, Daniel Black wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1768/
> -----------------------------------------------------------
> 
> (Updated 2009-10-22 14:37:57)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> This patch displays the List{-ID,post,subscriber,unsubscribe,archive,help,owner} \
> RFC2369, List-ID is RFC2919 and Archived-At (RFC5064) URLs of email header fields \
> on header context of kmail preview pane. 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdepim/kmail/kmmainwidget.h 1038827 
> /trunk/KDE/kdepim/kmail/kmmainwidget.cpp 1038827 
> /trunk/KDE/kdepim/kmail/mailinglist-magic.h 1038827 
> /trunk/KDE/kdepim/kmail/mailinglist-magic.cpp 1038827 
> /trunk/KDE/kdepim/kmail/messageactions.h 1038827 
> /trunk/KDE/kdepim/kmail/messageactions.cpp 1038827 
> 
> Diff: http://reviewboard.kde.org/r/1768/diff
> 
> 
> Testing
> -------
> 
> tested on kmail-1.12.1 (kde-4.3.1)
> 
> 
> Screenshots
> -----------
> 
> kmail context menu with mailing list info
> http://reviewboard.kde.org/r/1768/s/233/
> 
> 
> Thanks,
> 
> Daniel
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]