[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request: adds kmail support for RFC2369,
From:       "Daniel Black" <daniel.subs () internode ! on ! net>
Date:       2009-10-22 14:37:57
Message-ID: 20091022143757.23016.89216 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1768/
-----------------------------------------------------------

(Updated 2009-10-22 14:37:57.065049)


Review request for KDE PIM.


Changes
-------

Changed to context menu as per picture. Thanks Thomas/Ingo for SLOT/connect help.

Currently uses reply-list-to as an icon. Its easy enough to take the blue bit off it \
for a list icon. How do these changes happen? I can edit the svg easy enough however \
is a system icon for email lists justified and/or what course is recommended here?

Its still missing from the Messages menu and the context menu of the email list pane. \
Ran out of time there and was assuming some normalisation of these action lists was \
going to happen sometime.

As stated previously the commenting of mailinglist-magic.h,cpp maybe isn't the \
greatest however I didn't write the class and are only extending it a bit.


Summary (updated)
-------

This patch displays the List{-ID,post,subscriber,unsubscribe,archive,help,owner} \
RFC2369, List-ID is RFC2919 and Archived-At (RFC5064) URLs of email header fields on \
header context of kmail preview pane.


Diffs (updated)
-----

  /trunk/KDE/kdepim/kmail/kmmainwidget.h 1038827 
  /trunk/KDE/kdepim/kmail/kmmainwidget.cpp 1038827 
  /trunk/KDE/kdepim/kmail/mailinglist-magic.h 1038827 
  /trunk/KDE/kdepim/kmail/mailinglist-magic.cpp 1038827 
  /trunk/KDE/kdepim/kmail/messageactions.h 1038827 
  /trunk/KDE/kdepim/kmail/messageactions.cpp 1038827 

Diff: http://reviewboard.kde.org/r/1768/diff


Testing
-------

tested on kmail-1.12.1 (kde-4.3.1)


Screenshots
-----------

kmail context menu with mailing list info
  http://reviewboard.kde.org/r/1768/s/233/


Thanks,

Daniel

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]