[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request: adds kmail support for RFC2369,
From:       "Thomas McGuire" <mcguire () kde ! org>
Date:       2009-10-22 16:28:37
Message-ID: 20091022162837.25722.90638 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1768/#review2769
-----------------------------------------------------------


Thanks, that looks a lot better than the initial links in the reader window :)
I've made a bunch of comments, but nothing big, the patch is ok in the larger \
picture.


/trunk/KDE/kdepim/kmail/kmmainwidget.cpp
<http://reviewboard.kde.org/r/1768/#comment2106>

    You'd think you'd get away without spaces inside the parenthesis here? ;)



/trunk/KDE/kdepim/kmail/mailinglist-magic.cpp
<http://reviewboard.kde.org/r/1768/#comment2107>

    Add a newline above this line



/trunk/KDE/kdepim/kmail/messageactions.h
<http://reviewboard.kde.org/r/1768/#comment2108>

    kurl.h > KUrl



/trunk/KDE/kdepim/kmail/messageactions.h
<http://reviewboard.kde.org/r/1768/#comment2109>

    There should be documentation for those new two methods, it is not obvious what \
they do.



/trunk/KDE/kdepim/kmail/messageactions.h
<http://reviewboard.kde.org/r/1768/#comment2110>

    Spaces and CamelCase, please
    Btw, the whole patch can have an improvement in coding style, I didn't comment \
the other issues from now on.



/trunk/KDE/kdepim/kmail/messageactions.cpp
<http://reviewboard.kde.org/r/1768/#comment2111>

    Use the forwarding headers KRun and KMenu



/trunk/KDE/kdepim/kmail/messageactions.cpp
<http://reviewboard.kde.org/r/1768/#comment2112>

    Mailing-List Information is too long IMHO, just use "Mailing List" (also without \
the hyphen, since that is what is used in the folder menu)



/trunk/KDE/kdepim/kmail/messageactions.cpp
<http://reviewboard.kde.org/r/1768/#comment2114>

    What does this action do? Putting a non-verb as the action text should usually \
not be done.  Is there anything this action does that the actions below don't?



/trunk/KDE/kdepim/kmail/messageactions.cpp
<http://reviewboard.kde.org/r/1768/#comment2113>

    Missing i18n in all these guys



/trunk/KDE/kdepim/kmail/messageactions.cpp
<http://reviewboard.kde.org/r/1768/#comment2116>

    add a const in front of QVariant here



/trunk/KDE/kdepim/kmail/messageactions.cpp
<http://reviewboard.kde.org/r/1768/#comment2115>

    Set a parent instead of 0 here, mParent from MessageActions will probably do.



/trunk/KDE/kdepim/kmail/messageactions.cpp
<http://reviewboard.kde.org/r/1768/#comment2117>

    No need to write out "warn", it is already a kWarning after all



/trunk/KDE/kdepim/kmail/messageactions.cpp
<http://reviewboard.kde.org/r/1768/#comment2118>

    foreach is more readable, but that is just personal preference



/trunk/KDE/kdepim/kmail/messageactions.cpp
<http://reviewboard.kde.org/r/1768/#comment2120>

    add const. and rename it, pUrl sounds suspiciously like Hungarian notation :)
    Variables should not need to be abbreviated in the days of code completion.



/trunk/KDE/kdepim/kmail/messageactions.cpp
<http://reviewboard.kde.org/r/1768/#comment2121>

    I think .arg() will not with with i18nc and produce incorrect strings at runtime.


- Thomas


On 2009-10-22 14:37:57, Daniel Black wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1768/
> -----------------------------------------------------------
> 
> (Updated 2009-10-22 14:37:57)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> This patch displays the List{-ID,post,subscriber,unsubscribe,archive,help,owner} \
> RFC2369, List-ID is RFC2919 and Archived-At (RFC5064) URLs of email header fields \
> on header context of kmail preview pane. 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdepim/kmail/kmmainwidget.h 1038827 
> /trunk/KDE/kdepim/kmail/kmmainwidget.cpp 1038827 
> /trunk/KDE/kdepim/kmail/mailinglist-magic.h 1038827 
> /trunk/KDE/kdepim/kmail/mailinglist-magic.cpp 1038827 
> /trunk/KDE/kdepim/kmail/messageactions.h 1038827 
> /trunk/KDE/kdepim/kmail/messageactions.cpp 1038827 
> 
> Diff: http://reviewboard.kde.org/r/1768/diff
> 
> 
> Testing
> -------
> 
> tested on kmail-1.12.1 (kde-4.3.1)
> 
> 
> Screenshots
> -----------
> 
> kmail context menu with mailing list info
> http://reviewboard.kde.org/r/1768/s/233/
> 
> 
> Thanks,
> 
> Daniel
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]