[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] [PATCH] Kleo::KeySelectionDialog allows selecting
From:       Ingo =?iso-8859-15?q?Kl=F6cker?= <kloecker () kde ! org>
Date:       2006-05-09 13:54:34
Message-ID: 200605091554.35646 () helena ! mathA ! rwth-aachen ! de
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


Am Freitag, 5. Mai 2006 23:01 schrieb Stefan Gehn:
> Moin,
>
> just stumbled across this small race-condition. If you're fast enough
> you can select an invalid key for signing/encrypting. Fast enough
> here means selecting a key and clicking OK before
> slotCheckSelection() is called (it's async).
>
> The problem is in Kleo::KeySelectionDialog::slotOk() where the
> key-selection gets checked one last time. If that check disables the
> OK button, accept() is called nevertheless and one ends up with an
> key that is not usable for signing/encryption.

Hmm, maybe the OK button should be disabled by default and should only 
be enabled if everything is okay. Currently, it seems to be the other 
way around.

Regards,
Ingo

[Attachment #5 (application/pgp-signature)]

_______________________________________________
kde-pim mailing list
kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/

[prev in list] [next in list] [prev in thread] [next in thread]