[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] [PATCH] Kleo::KeySelectionDialog allows selecting
From:       Allen Winter <winter () kde ! org>
Date:       2006-05-07 15:48:30
Message-ID: 200605071148.31588.winter () kde ! org
[Download RAW message or body]

On Friday 05 May 2006 17:01, Stefan Gehn wrote:
> Moin,
> 
> just stumbled across this small race-condition. If you're fast enough you can 
> select an invalid key for signing/encrypting. Fast enough here means 
> selecting a key and clicking OK before slotCheckSelection() is called (it's 
> async).
> 
> The problem is in Kleo::KeySelectionDialog::slotOk() where the key-selection 
> gets checked one last time. If that check disables the OK button, accept() is 
> called nevertheless and one ends up with an key that is not usable for 
> signing/encryption.
> 
> Attached is a patch against 3.5 branch that applies inside 
> kdepim/certmanager/lib
> 
> Would be cool if somebody can check if I can commit this :)
> 
Thanks for the patch mETz.
Committed to branch and forward ported to trunk.

-- 
Let's Keep the Political Talk Out of KDE PLEASE
_______________________________________________
kde-pim mailing list
kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]