[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    RE: [Kde-pim] Better error handling for exchange plugin
From:       "Best, Jan-Pascal van" <j.p.vanbest () tbm ! tudelft ! nl>
Date:       2002-10-30 7:36:44
[Download RAW message or body]

> Some comments:
> - The KMessagebox call should have the mainWindow() as parent, not 0.
> - The error messages should probably be ended with a ".", as 
> these are 
> complete sentences.
> - I would remove the "shoot me" error message and make this 
> case use the default branch of the switch.
Thanks, I've made those changes.

> Other than that the patch looks fine. I haven't tested it, 
> though, so I 
> can't guarantee that it doesn't break the plugin.
I tested it thoroughly, but I asked you to look it over, too,
because of the release process phase we're in. Works fine here.

Jan-Pascal
_______________________________________________
kde-pim mailing list
kde-pim@mail.kde.org
http://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]