[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Distibution List Editor
From:       Mike Pilone <mpilone () slac ! com>
Date:       2002-05-21 13:48:39
[Download RAW message or body]

Ok,

I have looked over the changes and they are improvements, but I am still not 
comfortable with the dialog. I still do not like the combo box, since you 
cannot see all the defined lists at once. I also do not like the buttons 
across the top and bottom:
1) because they have different layout and spacing
2) they make me think that we are trying to get toolbar functionality 
without using a toolbar.

I think things need to be better grouped. Also, about the icons, there 
appears to be a KDE wide setting someplace for having icons on buttons. We 
should probably honor that (keeping the text, I lost that vote ;).

Possible improvements:
Can we create a group box on the left, with a list box of dist list names 
and a stack of buttons (with text) under the listbox (still in the group 
box) for add, remove, rename.
On the right we can have another groupbox with a list view of contacts in 
it. The contacts are a tree, with the formatted name (or realname) as the 
parent/root items and the email addresses as child items. Child items would 
be check box list view items. Next to the parent item (formatted name), we 
can have an icon indicating if the person is in the dist list or not. This 
icon would be enabled if any of the email addresses (child items) are 
checked.

This idea comes from the changes that the kde usablity team is doing. They 
appear to be replacing the selection widget (the one with 2 list boxes and 
arrows between them) with listviews of check box items. This also greatly 
simplifies the interface by removing the add/remove/select email buttons 
that we have yet to find a good location for.

What does everyone think?

BTW: Tobias, thanks for your help. Please don't take my comments as not 
appreciating your help.

-mike

On Sunday 19 May 2002 03:23 pm, Tobias Koenig wrote:
> On Thu, May 16, 2002 at 11:13:00AM -0400, Mike Pilone wrote:
> > However, I feel like problems still exist with the new layout:
>
> I've looked at the DistributionListEditor one more time and
>
> changed the following things:
> > - The  two lists have no indication of what they are. A user must make
> > the assumption that one list is available and one is selected.
>
> Added labels for description. Is it ok so?
>
> > - The 'Add Entry' button is under the available list. This implies that
> > adding effects that list, but infact pressing that button removes the
> > entry from the available list and adds it to the other list (which
> > again isn't labeled). The same can be said for remove entry, accept it
> > actually removes the entry from the list (adding a new one to the other
> > list).
>
> Where do you want to place the 'Add' button? It is the only logical place
> for.
>
> > - I don't understand the 'Preferred Email' column. I presume that is to
> > show the user if he/she is using the receiver's preferred email.
>
> ... and you can select an other email address for the user in this
> special distribution list. So IMHO the column is ok.
>
> > A bug also exists that the preferred email label is not updated if I
> > change the email address, then change it back to the preferred email
> > address.
>
> Will look at it
>
> > - There is a bug that a email address is not selected when the user
> > clicks the 'Change Email' button.
>
> If no email address is selected in the dialog, the 'preferred address'
> will automagically selected when clicking 'Apply'.
>
> > - There is a bug on bugs.kde.org saying that dist lists cannot be
> > renamed. This is because the dialog doesn't provide it.
>
> Now it does :)
>
> > - There is no Ok, Cancel or Apply button (standard KDE dialog buttons).
>
> Hmm right, will look at it.
>
> > - I do not like large amounts of text on a button that could be
> > represented with a standard icon and a tool tip.
>
> What says the styleguide to this issue?
>
> > - Removing a list causes the dialog to crash (testdistlist). I think
> > this is something new, however.
>
> Fixed, I introduced it with mList.setAutoDelete(true)
> in DistributionListManager.
>
> Ciao,
> Tobias

-- 
Mike Pilone <mpilone@slac.com>        http://www.slac.com/mpilone/personal/
GPG Fingerprint = 856C 8B36 ECF7 9156 4611  7C6B C265 05C4 162F C3B5

See http://www.slac.com/mpilone/personal/mpilone_pub_key.gpg for full key.
See http://www.gnupg.org for GPG information.
_______________________________________________
kde-pim mailing list
kde-pim@mail.kde.org
http://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]