[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D15143: Allow creation of separator Actions
From:       Dimitris Kardarakos <noreply () phabricator ! kde ! org>
Date:       2018-09-28 9:07:58
Message-ID: 18c9f19c2110e85aedac2093ce84f501 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

dkardarakos updated this revision to Diff 42465.
dkardarakos added a comment.


  Previously introduced "separator mode" removed from AbstractListItem and \
BasicListItem.  
  Instead of a solution totally inside globaldrawer and contextdrawer I opted for a \
new BasicListItem alias property (reserveSpaceForLabel) similar to the existing \
reserveSpaceForIcon. With this approach we have more control when adding new items \
(like the Separator) to BasicListItems.

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15143?vs=40647&id=42465

REVISION DETAIL
  https://phabricator.kde.org/D15143

AFFECTED FILES
  src/controls/Action.qml
  src/controls/BasicListItem.qml
  src/controls/ContextDrawer.qml
  src/controls/GlobalDrawer.qml
  src/controls/private/ActionsMenu.qml

To: dkardarakos, mart
Cc: broulik, plasma-devel, dkardarakos, apol, davidedmundson, mart, hein


[Attachment #3 (text/html)]

<table><tr><td style="">dkardarakos updated this revision to Diff 42465.<br \
/>dkardarakos added a comment. </td><a style="text-decoration: none; padding: 4px \
8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; \
border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D15143">View Revision</a></tr></table><br \
/><div><div><p>Previously introduced &quot;separator mode&quot; removed from \
AbstractListItem and BasicListItem.</p>

<p>Instead of a solution totally inside globaldrawer and contextdrawer I opted for a \
new BasicListItem alias property (reserveSpaceForLabel) similar to the existing \
reserveSpaceForIcon. With this approach we have more control when adding new items \
(like the Separator) to BasicListItems.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R169 Kirigami</div></div></div><br \
/><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a \
href="https://phabricator.kde.org/D15143?vs=40647&amp;id=42465">https://phabricator.kde.org/D15143?vs=40647&amp;id=42465</a></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D15143">https://phabricator.kde.org/D15143</a></div></div><br \
/><div><strong>AFFECTED FILES</strong><div><div>src/controls/Action.qml<br /> \
src/controls/BasicListItem.qml<br /> src/controls/ContextDrawer.qml<br />
src/controls/GlobalDrawer.qml<br />
src/controls/private/ActionsMenu.qml</div></div></div><br /><div><strong>To: \
</strong>dkardarakos, mart<br /><strong>Cc: </strong>broulik, plasma-devel, \
dkardarakos, apol, davidedmundson, mart, hein<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]