[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D15599: Port the "Switch Desktop" containment action to libtaskmanager
From: David Edmundson <noreply () phabricator ! kde ! org>
Date: 2018-09-28 8:54:12
Message-ID: 7cf39d611603f4b7a3ac222377b5cd15 () localhost ! localdomain
[Download RAW message or body]
[Attachment #2 (text/plain)]
davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> desktop.cpp:59
> + const QVariantList &desktopIds = s_virtualDesktopInfo->desktopIds();
> + const QStringList &desktopNames = s_virtualDesktopInfo->desktopNames();
> + const QVariant ¤tDesktop = s_virtualDesktopInfo->currentDesktop();
Use of the & is weird.
> desktop.cpp:108
> +
> + const int nextDesktopIndex = (currentDesktopIndex % desktopIds.count() + 1);
> +
I /think/ this is wrong. Not 100% sure.
We used to want a number wrapped between 1 and numDesktops.
The old
KWindowSystem::setCurrentDesktop(currentDesktop % numDesktops + 1);
is probably more understandable as
KWindowSystem::setCurrentDesktop((currentDesktop +1 ) -1 % numDesktops + 1);
In the new code as we have the IDs in a lookup table so we want our final number to \
be between 0 and numDesktops-1
Therefore should this be
currentDesktopIndex +1 % desktopIds.count();
?
(same for perform previous)
> broulik wrote in desktop.cpp:46
> `!s_instanceCount`
In the other patch VirtualDesktopInfo has a shared d ptr across all instances.
There's no point making VirtualDesktopInfo shared when it internally does it itself \
anyway. You save practically nothing.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D15599
To: hein, mart, davidedmundson
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart
[Attachment #3 (text/html)]
<table><tr><td style="">davidedmundson requested changes to this revision.<br \
/>davidedmundson added inline comments.<br />This revision now requires changes to \
proceed. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; \
float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D15599">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D15599#inline-85279">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">desktop.cpp:59</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
style="color: #aa4000">const</span> <span class="n">QVariantList</span> <span \
style="color: #aa2211">&</span><span class="n">desktopIds</span> <span \
style="color: #aa2211">=</span> <span class="n">s_virtualDesktopInfo</span><span \
style="color: #aa2211">-></span><span class="n">desktopIds</span><span \
class="p">();</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> <span \
class="n">QStringList</span> <span style="color: #aa2211">&</span><span \
class="n">desktopNames</span> <span style="color: #aa2211">=</span> <span \
class="n">s_virtualDesktopInfo</span><span style="color: #aa2211">-></span><span \
class="n">desktopNames</span><span class="p">();</span> </div><div style="padding: 0 \
8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: \
#aa4000">const</span> <span class="n">QVariant</span> <span style="color: \
#aa2211">&</span><span class="n">currentDesktop</span> <span style="color: \
#aa2211">=</span> <span class="n">s_virtualDesktopInfo</span><span style="color: \
#aa2211">-></span><span class="n">currentDesktop</span><span class="p">();</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">Use of the & is weird.</p></div></div><br /><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D15599#inline-85469">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">desktop.cpp:108</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
style="color: #aa4000">const</span> <span style="color: #aa4000">int</span> <span \
class="n">nextDesktopIndex</span> <span style="color: #aa2211">=</span> <span \
class="p">(</span><span class="n">currentDesktopIndex</span> <span style="color: \
#aa2211">%</span> <span class="n">desktopIds</span><span class="p">.</span><span \
class="n">count</span><span class="p">()</span> <span style="color: #aa2211">+</span> \
<span style="color: #601200">1</span><span class="p">);</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I \
/think/ this is wrong. Not 100% sure.</p>
<p style="padding: 0; margin: 8px;">We used to want a number wrapped between 1 and \
numDesktops.</p>
<p style="padding: 0; margin: 8px;">The old<br />
KWindowSystem::setCurrentDesktop(currentDesktop % numDesktops + 1);</p>
<p style="padding: 0; margin: 8px;">is probably more understandable as<br />
KWindowSystem::setCurrentDesktop((currentDesktop +1 ) -1 % numDesktops + 1);</p>
<p style="padding: 0; margin: 8px;">In the new code as we have the IDs in a lookup \
table so we want our final number to be between 0 and numDesktops-1</p>
<p style="padding: 0; margin: 8px;">Therefore should this be<br />
currentDesktopIndex +1 % desktopIds.count();</p>
<p style="padding: 0; margin: 8px;">?</p>
<p style="padding: 0; margin: 8px;">(same for perform previous)</p></div></div><br \
/><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D15599#inline-84161">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">broulik</span> wrote in <span \
style="color: #4b4d51; font-weight: bold;">desktop.cpp:46</span></div> <div \
style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: \
8px;"><tt style="background: #ebebeb; font-size: \
13px;">!s_instanceCount</tt></p></div></div> <div style="margin: 8px 0; padding: 0 \
12px;"><p style="padding: 0; margin: 8px;">In the other patch VirtualDesktopInfo has \
a shared d ptr across all instances.</p>
<p style="padding: 0; margin: 8px;">There's no point making VirtualDesktopInfo \
shared when it internally does it itself anyway. You save practically \
nothing.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D15599">https://phabricator.kde.org/D15599</a></div></div><br \
/><div><strong>To: </strong>hein, mart, davidedmundson<br /><strong>Cc: \
</strong>broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic