[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D14476: QMLScreen: do not declare the engine a member
From:       Roman Gilg <noreply () phabricator ! kde ! org>
Date:       2018-07-30 7:29:15
Message-ID: 051fccad94474c7d0f39deb949d70b30 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

romangg accepted this revision.
romangg added a comment.
This revision is now accepted and ready to land.


  Note, that m_engine is set in widget.cpp. But it's just a Cpp call to setEngine, \
which is defined extra. So removing the property macro should be fine.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D14476

To: gladhorn, #plasma, romangg
Cc: romangg, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">romangg accepted this revision.<br />romangg added a \
comment.<br />This revision is now accepted and ready to land. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D14476">View \
Revision</a></tr></table><br /><div><div><p>Note, that m_engine is set in widget.cpp. \
But it&#039;s just a Cpp call to setEngine, which is defined extra. So removing the \
property macro should be fine.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R104 KScreen</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D14476">https://phabricator.kde.org/D14476</a></div></div><br \
/><div><strong>To: </strong>gladhorn, Plasma, romangg<br /><strong>Cc: \
</strong>romangg, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]