[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D14476: QMLScreen: do not declare the engine a member
From:       Kai Uwe Broulik <noreply () phabricator ! kde ! org>
Date:       2018-07-30 7:36:21
Message-ID: c322d6a979429ece76efcb823c495250 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

broulik added inline comments.

INLINE COMMENTS

> qmlscreen.h:109
> 
> QQmlEngine* m_engine = nullptr;
> QMLOutput *m_leftmost = nullptr;

This entire custom engine handling could be removed, with `QMLScreen` using \
`qmlEngine(this)` when creating an `QMLOutput`

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D14476

To: gladhorn, #plasma, romangg
Cc: broulik, romangg, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">broulik added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D14476">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D14476#inline-76337">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">qmlscreen.h:109</span></div> <div \
style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; ">    <span class="n">QQmlEngine</span><span \
style="color: #aa2211">*</span> <span class="n">m_engine</span> <span style="color: \
#aa2211">=</span> <span class="n">nullptr</span><span class="p">;</span> </div><div \
style="padding: 0 8px; margin: 0 4px; ">    <span class="n">QMLOutput</span> <span \
style="color: #aa2211">*</span><span class="n">m_leftmost</span> <span style="color: \
#aa2211">=</span> <span class="n">nullptr</span><span class="p">;</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">This entire custom engine handling could be removed, with <tt \
style="background: #ebebeb; font-size: 13px;">QMLScreen</tt> using <tt \
style="background: #ebebeb; font-size: 13px;">qmlEngine(this)</tt> when creating an \
<tt style="background: #ebebeb; font-size: \
13px;">QMLOutput</tt></p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R104 KScreen</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D14476">https://phabricator.kde.org/D14476</a></div></div><br \
/><div><strong>To: </strong>gladhorn, Plasma, romangg<br /><strong>Cc: \
</strong>broulik, romangg, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]