[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D14436: SwitchDesktop mousewheel options with config dialog added
From:       Thomas Otto <noreply () phabricator ! kde ! org>
Date:       2018-07-28 8:00:15
Message-ID: 724fb8666d8f50cfcd1834217cb5736c () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

totto added inline comments.

INLINE COMMENTS

> desktop.cpp:36
> +constexpr const char *cfgKeyProperty = "cfgKey";
> +bool readKwinrcRollOverDesktops() {
> +    auto cfg = KSharedConfig::openConfig("kwinrc");

The rollover option is from another kde component (kwin), is there a way to get \
notified whenever this config changes?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14436

To: totto, hein, broulik
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">totto added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D14436">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D14436#inline-76083">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">desktop.cpp:36</span></div> <div \
style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span \
style="color: #aa4000">constexpr</span> <span style="color: #aa4000">const</span> \
<span style="color: #aa4000">char</span> <span style="color: #aa2211">*</span><span \
class="n">cfgKeyProperty</span> <span style="color: #aa2211">=</span> <span \
style="color: #766510">&quot;cfgKey&quot;</span><span class="p">;</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span \
style="color: #aa4000">bool</span> <span style="color: \
#004012">readKwinrcRollOverDesktops</span><span class="p">()</span> <span \
class="p">{</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);">    <span style="color: #aa4000">auto</span> <span \
class="n">cfg</span> <span style="color: #aa2211">=</span> <span \
class="n">KSharedConfig</span><span style="color: #aa2211">::</span><span \
class="n">openConfig</span><span class="p">(</span><span style="color: \
#766510">&quot;kwinrc&quot;</span><span class="p">);</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">The \
rollover option is from another kde component (kwin), is there a way to get notified \
whenever this config changes?</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D14436">https://phabricator.kde.org/D14436</a></div></div><br \
/><div><strong>To: </strong>totto, hein, broulik<br /><strong>Cc: \
</strong>plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]