[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D14437: Fix QFileDialog not remembering the last visited directory.
From:       David Faure <noreply () phabricator ! kde ! org>
Date:       2018-07-28 11:27:52
Message-ID: 4641bb2179bc1819afd8206011c133dd () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

dfaure created this revision.
dfaure added reviewers: anthonyfieroni, elvisangelaccio, plasma-devel, broulik, arichardson.
Restricted Application added a project: Plasma.
dfaure requested review of this revision.

REVISION SUMMARY
  This regression (compared to kdelibs4's direct KFileDialog usage) came
  from the fact that QFileDialog's lastVisited() only gets updated if
  the helper emits directoryEntered.
  
  So QFileDialog was setting the current dir as startDir every single
  time, overriding's KFileWidget's own logic for reusing the last dir
  initially.

TEST PLAN
  QFileDialog::getOpenFileName(this, i18n("Select file"));
  twice in a row, from the same process.

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  Plasma/5.13

REVISION DETAIL
  https://phabricator.kde.org/D14437

AFFECTED FILES
  src/platformtheme/kdeplatformfiledialoghelper.cpp

To: dfaure, anthonyfieroni, elvisangelaccio, plasma-devel, broulik, arichardson
Cc: ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Attachment #3 (text/html)]

<table><tr><td style="">dfaure created this revision.<br />dfaure added reviewers: \
anthonyfieroni, elvisangelaccio, plasma-devel, broulik, arichardson.<br />Restricted \
Application added a project: Plasma.<br />dfaure requested review of this revision. \
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D14437">View Revision</a></tr></table><br \
/><div><strong>REVISION SUMMARY</strong><div><p>This regression (compared to \
kdelibs4&#039;s direct KFileDialog usage) came<br /> from the fact that \
QFileDialog&#039;s lastVisited() only gets updated if<br /> the helper emits \
directoryEntered.</p>

<p>So QFileDialog was setting the current dir as startDir every single<br />
time, overriding&#039;s KFileWidget&#039;s own logic for reusing the last dir<br />
initially.</p></div></div><br /><div><strong>TEST \
PLAN</strong><div><p>QFileDialog::getOpenFileName(this, i18n(&quot;Select \
file&quot;));<br /> twice in a row, from the same process.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R135 Integration for Qt applications in \
Plasma</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>Plasma/5.13</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D14437">https://phabricator.kde.org/D14437</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>src/platformtheme/kdeplatformfiledialoghelper.cpp</div></div></div><br \
/><div><strong>To: </strong>dfaure, anthonyfieroni, elvisangelaccio, plasma-devel, \
broulik, arichardson<br /><strong>Cc: </strong>ragreen, Pitel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]